Posted by effulgentsia on February 1, 2013 at 4:15am
4 followers
| Project: | Drupal core |
| Version: | 8.x-dev |
| Component: | other |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Wim Leers |
| Status: | closed (duplicate) |
| Issue tags: | CKEditor in core |
Issue Summary
I tried #1890502-84: WYSIWYG: Add CKEditor module to core on Firefox and Chrome. In both cases, when I add the U (underline) button to the toolbar for the Full HTML format, then when I go to edit some text in that format, the toolbar does not include that button.
I breakpointed Drupal.editors.ckeditor.attach() and found that the Underline button item does exist as expected in format.editorSettings passed to CKEDITOR.replace(), so I don't know if it's a bug with CKEditor itself, or if there's some other incompatibility in what's passed.
Comments
#1
Tagging
#2
#3
This is because CKEditor loads its default config.js file with the default config, which contains:
config.removeButtons = 'Underline,Subscript,Superscript';In previous iterations of the patch at #1890502: WYSIWYG: Add CKEditor module to core, we explicitly unlisted these buttons to be removed.
I consulted with the wwalc of the CKEditor guys, and attached is a patch that implements the proper way to ignore the default config file, and only listen to our instructions instead.
#4
Now with updated tests.
#5
Thanks. Since #1890502: WYSIWYG: Add CKEditor module to core needed a reroll anyway, I merged this into it.
#6
Excellent — thanks!