Download & Extend
jQuery Update » Issues

Use the HTTPS version when necessary and only when necessary

Posted by dalin on February 1, 2013 at 6:22pm
Project:jQuery Update
Version:7.x-2.x-dev
Component:Code
Category:bug report
Priority:major
Assigned:Unassigned
Status:reviewed & tested by the community

Issue Summary

Both the Google and MS CDNs can be used over HTTP and HTTPS. We should use the appropriate protocol where necessary to ensure best performance and to eliminate browser warnings about mixed HTTP(S) content.

This should also clear up these issues:
#1309276: Microsoft CDN not using https version of file when under ssl
#1596480: Google CDN is only available via SSL

Login or register to post comments

Comments

#1

Posted by dalin on February 1, 2013 at 6:26pm
Assigned to:dalin» Anonymous
Status:active» needs review
AttachmentSize
1905634-jquery_update_https-1.patch 2.11 KB

#2

Posted by ericduran on April 8, 2013 at 8:09pm
Status:needs review» reviewed & tested by the community

Looks good to me.

I'll test and commit this later.

Thanks.

#3

Posted by dale386 on April 15, 2013 at 8:10pm

This works for me. Thanks!

#4

Posted by Murz on May 9, 2013 at 7:17am

Thanks, works very well, waiting commit.

#5

Posted by Murz on May 9, 2013 at 7:33am

Also will be good to change https into block:

<?php
  switch($cdn) {
    case 'google':
      $cdn = 'http://ajax.googleapis.com/ajax/libs/jqueryui/1.8.11/jquery-ui' . $min . '.js';
      jquery_update_jqueryui_cdn($cdn, $javascript, $path, $min, $names);
      jquery_update_jqueryui_backup($javascript, $path, $min);
      break;
    case 'microsoft':
      $cdn = 'http://ajax.aspnetcdn.com/ajax/jquery.ui/1.8.11/jquery-ui' . $min . '.js';
      jquery_update_jqueryui_cdn($cdn, $javascript, $path, $min, $names);
      jquery_update_jqueryui_backup($javascript, $path, $min);
      break;
    case 'none':
      jquery_update_jqueryui_local($javascript, $path, $min, $names);
      break;
  }
?>

Updated patch is attached.
AttachmentSize
1905634-jquery_update_https-2.patch 3.17 KB