Hi there,

I was checking out a certain page with Firebug and noticed that certain lines started with "$spacing" and appeared not correctly indented.
I checked the code and found that drupalforfirebug.module line 347 reads:
$output .= '<div>$spacing <span style="color: grey;"> [' . $key .'] => stdClass (' . $colorend .'</div>';
which obviously prevents $spacing to be replaced with its content.
I think the correct line should be:
$output .= '<div>'. $spacing .'<span style="color: grey;"> [' . $key .'] => stdClass (' . $colorend .'</div>';

Nothing major but...

I wanted to learn how to submit patches, but I am still working on learning how to... sorry.
Thanks
Dario

CommentFileSizeAuthor
#2 spacingappearsinoutput-1905878-1.patch739 bytessavedario

Comments

frob’s picture

frob
Primary language English
commented
Version: 6.x-1.4 » 7.x-1.x-dev

I see, good catch.

If you can please work of off the 7.x branch and then back port your patch to 6.x. If you click on the version control tab in the project window then it has instructions on how to submit a patch.

I will probably update the dev branchs sometime tonight

savedario’s picture

savedario commented
StatusFileSize
new spacingappearsinoutput-1905878-1.patch739 bytes

Hi there,

Thanks for hint on creating patches.
Here's the one I came up with.

frob’s picture

frob
Primary language English
commented
Status: Active » Fixed

Thank you very much for the patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.