Affiliated content edit operator (admin/domain/content/all)

I really did not understand this report.

Step-by-step explanation of the behavior (and what you expected) would be helpful. Screenshots also can help.

Remember that if you have 'administer nodes' permission or 'edit TYPE nodes' permission(s), then the access check will return TRUE.

If this is the case, you should see a warning message that says 'Your permissions allow you to see content...'

Test one more thing for me:

Do you have the "Domain-based editing controls" set to "Use access control for editors"?

This setting is at 'admin/build/domain' -- the Domain Access settings page.

If this option is not checked, the edit permission is not stored in the node_access table, and would produce the error you report.

You might also turn on the 'Show debugging output on node view' while you are building the site. If you want to use domain-specific editing, for each node you should see an list of 'Editors' assigned to the node. If that is blank, it means that the domain-specific editor permissions are not being saved.

This problem you report is probably a user interface bug, not a functionality bug. I should probably disable the 'edit domain nodes' permission if the setting isn't turned on.

OK, I confirmed the problem that you report. The issue is that some nodes were created while 'Use access control for editors' was turned off.

This is covered in the documentation, but probably isn't clear.

----
2.4 Setting DOMAIN_EDITOR_RULE

This is an advanced instruction, and may be ignored.

At the top of the domain.module file, you will find this line:

define('DOMAIN_EDITOR_RULE', FALSE);

This setting controls the default behavior for affiliate editors. If
DOMAIN_INSTALL_RULE is set to FALSE, you may change this value to TRUE if you
intend to use editing controls.

If this is set to TRUE and DOMAIN_INSTALL_RULE is set to FALSE, all existing
nodes on your site will be editable by users who are assigned as editors of your
root domain.

See section 3 and section 5 for more information.

This means that if you have content _before_ you enable the Domain Access module and you wish to use domain-specific editing rules, you should set this value to TRUE _before_ enabling the module.

----
3.3 Advanced Usage

In the event that you wish to segregate which content certain editors can
control, you should not use the normal 'edit TYPE nodes' permission provided
by Drupal's core Node module. This permisson grants the ability for a user
to edit all nodes of a given type.

In the Domain Access model, this permission is not used in favor of the provided
'edit domain nodes' permission. This permission allows editors only to edit
(and delete) nodes that belong to their subdomain.

To enable this feature, you should grant the 'edit domain nodes' permission to
some roles. Then you should enable the 'Use access control for editors' setting
under the Domain Access configuration screen.

I think this is pretty clear.

There are also some advanced notes in section 5 of the README.

I think changing this function will remove the problem:

function domain_content_check($domain, $all) {
  global $user;
  $rule = variable_get('domain_editors', DOMAIN_EDITOR_RULE);
  $check = FALSE;
  $editor = FALSE;
  // Can this user see the default site?
  if ($rule && $domain['domain_id'] == 0 && $user->domain_user['-1'] == -1) {
    $editor = TRUE;
  }
  // Can this user see the active site?
  else if ($rule && $domain['domain_id'] > 0 && $domain['domain_id'] == $user->domain_user[$domain['domain_id']]) {
    $editor = TRUE;
  }
  if ($all || $editor) {
    $check = TRUE;
  }
  return $check;
}

I also made a change to the permissions for the module:

function domain_perm() {
  $rule = variable_get('domain_editors', DOMAIN_EDITOR_RULE);
  if ($rule) {
    return array('administer domains', 'set domain access', 'edit domain nodes');
  }
  else {
    return array('administer domains', 'set domain access');
  }  
}

These two changes should prevent this type of confusion.

Thanks for the bug report. This is beta after all, so we have to fix all these issues.

Not a problem, I'm releasing early in order to get more testing done.

By the way, which part of the Netherlands are you from? Some of my ancestors came to the U.S. from Utrecht in 1625.

We were in Holland in 2006, but it rained the whole time we were in Utrecht. We saw part of the Dom -- it was under repair -- but not much of the city.

Doesn't it rain every other hour in Holland? We were in:

- Maastricht
- Utrecht
- Rotterdam
- Den Haag
- Delft
- Amsterdam

It didn't rain in Maastricht, at least. (We loved Maastricht.)