When I go to use Live CSS and I select a CSS file to edit, I cannot scroll through the file. Before a scroll tab would appear on the side, now there is nothing.

CommentFileSizeAuthor
#18 scroll_ace.png66.44 KBsethu_sk
#11 live_css-ace_to_library-1906370-11.patch6.59 MBtomtech
#8 css js errors.png50.14 KBbrianlp

Comments

guybedford’s picture

guybedford commented

Thanks for reporting.

- Have you disabled js and css minification on the site?
- Have you waited until the page is finished loading before opening the tab?

If so, is there an error in the JavaScript console at all?

Would be much appreciated to track this down.

Seph’s picture

Seph commented

I went through the steps you outlined above. js and css minification were both disabled and I waited until the page finished loading. It still didn't work. Then I decided to try using Chrome instead of Safari and it worked. For some reason it isn't appearing or working correctly in Safari.

guybedford’s picture

guybedford commented

Hmm, this is odd as it is working fine for me in safari. Which version of Safari are you using? If you open up the console, can you see any JavaScript errors on the page?

Any info to help reproduce would be great.

hallsy’s picture

hallsy commented

I am having the same problem i am afraid i cant scroll down.

guybedford’s picture

guybedford commented

Can you confirm which browser you are using?

Also ensure you have css and js minification turned off.

If you check the JavaScript console do you see any errors?

hallsy’s picture

hallsy commented

sorry guy i am new to this.

I am using the latest version of safari on my macbook.

I dont know how to turn css and js minification off...

guybedford’s picture

guybedford commented

It sounds like this is some sort of Safari issue... strangely I'm not seeing it in my Safari though. Have you tried using Chrome instead?

brianlp’s picture

brianlp commented
StatusFileSize
new css js errors.png50.14 KB

It doesn't work in Safari but in Firefox. Chrome I don't know.

Attached the errors I get in Safari on a page where noting is going on exept a dropdown menu and an image enabled for colorbox. No errors until I click to open the live css drawer.

also:
(242) 42event.layerX and event.layerY are broken and deprecated in WebKit. They will be removed from the engine in the near future.

errors

guybedford’s picture

guybedford commented

It looks like the issue is in the Ace code editor itself.

An update of the Ace editor may well fix the issue in this case.

Patches welcome.

guybedford’s picture

guybedford commented
Status: Active » Closed (duplicate)

Closing as a duplicate of #1933222. If not feel free to reopen.

tomtech’s picture

tomtech commented
Issue summary: View changes
Status: Closed (duplicate) » Needs review
StatusFileSize
new live_css-ace_to_library-1906370-11.patch6.59 MB

I also cannot scroll when using safari.

Here is a patch against the latest dev.

Using the latest ACE editor does not exhibit this problem.

Attached is a patch that:

1) Removes the older ACE editor from the project
2) Implements the libraries API (dependency to Libraries added)
3) Adds a drush command to download the latest ACE editor
4) Adds a drush event that automatically downloads the editor when the module is enabled(through drush)

deryck.henson’s picture

deryck.henson commented

Unless Guy beats me to it, I'll investigate this soon. Thank you very much for the patch!

deryck.henson’s picture

deryck.henson commented
Status: Needs review » Patch (to be ported)
deryck.henson’s picture

deryck.henson commented

I like this and I am going to merge it. It works well and makes sense. I'm going to add a dependency in the .info file for libraries as well.

Thank you.

I have other unrelated updates that will be coming as well (mainly performance enhancements).

deryck.henson’s picture

deryck.henson commented
Component: User interface » Code
Assigned: Unassigned » deryck.henson
Status: Patch (to be ported) » Closed (fixed)

This was a great idea and I have it committed to the dev releases for testing in the community. I'm marking as closed until errors present that require the ticket be re-opened.

You will need to download ACE (http://ace.c9.io) for free and place it in your sites/***/libraries/ace folder.

Utilize latest git commit / dev release on project page to test and report bugs back here please.

Thanks

guybedford’s picture

guybedford commented

This sounds sensible - we should just ensure we document the process properly in the README so users can't get lost during the install process.

deryck.henson’s picture

deryck.henson commented

Most certainly. I'll probably look into putting a notification when the module is enabled without the library to go download it (same way modules like colorbox do it).

sethu_sk’s picture

sethu_sk commented
StatusFileSize
new scroll_ace.png66.44 KB

Hi Team,

I have installed Live_css module in drupal 7. I am having ace.js file issue when scroll the ace editor.
When i scroll the editor, it display "Uncaught TypeError: Cannot create property 'type' on number '120'" in console.

Kindly refer the attachment.

Please let us know if found any possible way to fix the issue.

Thanks,
Sethu K