Feeds Tamper Clone [#1906452]

This module provides an easy to use UI option to clone Feeds Tamper plugins when cloning a Feeds importer. The existing Feeds Tamper module does not offer this feature and I think it could be very helpful to people, so I built it.

My project page is currently located at: http://drupal.org/sandbox/project/1906440

My git repo:
git clone http://git.drupal.org/sandbox/mamanerd/1906440.git feeds_tamper_clone

This project is for Drupal 7.

Comments

Comment #1

cackle commented 3 February 2013 at 10:52

Status:

Needs review

» Needs work

hello,
1) please add git command - git clone http://git.drupal.org/sandbox/mamanerd/1906440.git feeds_tamper_clone
2) there are some errors on automatic review. See http://ventral.org/pareview/httpgitdrupalorgsandboxmamanerd1906440git
3) It seems you are working in the "master" branch in git. You should really be working in a version specific branch, in your case 7.x-1.x

Comment #2

mamanerd commented 3 February 2013 at 15:59

Hi Cackle,
Thanks for taking the time to review my module! I have fixed all of the issues that you listed above. Please let me know if you find anything else. Thanks again!

Comment #3

kalis1

Lyon

commented 5 February 2013 at 10:55

Hello !

I've reviewed your code and didn't see anything, except that I would change the formulation "Check this box if you want to clone the Feeds Tamper plugins for this importer, too." to "Check this box if you also want to clone the Feeds Tamper plugins for this importer."

However, I was wondering why you don't try to integrate your code to the feeds_tamper module instead of creating a new one ?

It would be the same logic as Feeds module which integrates the cloning feature
There are already some requests on the subject, see #1346936: Cloning/Exporting Feeds Importer doesn't work with Tamper

Comment #4

mamanerd commented 5 February 2013 at 19:03

Hi Kalis, thanks for the suggestion on changing the text! I agree that your wording makes more sense. :)

I suppose I could integrate into the Feeds Tamper module instead. I really just wanted to get my first contrib module under my belt, but I guess it makes more sense to integrate into the existing module.

If I do that though, where does it leave the status of this project? Do I delete it? Close it?

Comment #5

kalis1

Lyon

commented 6 February 2013 at 09:24

Hi mamanerd !

Good to see that you agree with my suggestion, which really seems to be the best choice. Plus, it appears that someone has already spread the word :) : http://drupal.org/node/1346936#comment-7032608

So, if I were you, I'd suggest a patch for the feeds_tamper module in #1346936: Cloning/Exporting Feeds Importer doesn't work with Tamper, and when the patch is applied, close the present issue as "duplicate".

Comment #6

mamanerd commented 10 February 2013 at 02:54

Status:

Needs work

» Closed (duplicate)

Thanks again for your help, Kalis! I've been working with Drupal for about a year now, but this is my first time going through the "official" process of contributing a module or adding a new patch, so thank you for your patience. I just added the patch to the issue thread (http://drupal.org/node/1346936#comment-7048514). I will close this issue out now as "duplicate".