Scenario: when creating a vocabulary and attach it to a group content, the terms of the vocabulary are referenced to the group content and we can see them on the node page. That's ok, the problem happening after removing the vocabulary from the bundle(i.e un-checking the bundle check box in the vocabulary edit page).

After some discussion in the issue we got the next solution: when removing the vocabulary from the group content we need to go over the terms that belong to the vocabulary and remove their reference from the content that belong to that group. All of this need to be done using the batch API.

CommentFileSizeAuthor
#7 1906672-og-vocab-advanced-queue-7.patch9.36 KBroysegall
#5 1906672-og-vocab-advanced-queue-5.patch9.12 KBroysegall
#4 1906672-og-vocab-advanced-queue-4.patch9.23 KBamitaibu
#2 leftover-og-vocab-taxonomy-term-1906672-2.patch9.49 KBroysegall
#1 leftover-og-vocab-taxonomy-term-1906672-1.patch9.29 KBroysegall

Comments

roysegall’s picture

roysegall commented
Status: Active » Needs review
StatusFileSize
new leftover-og-vocab-taxonomy-term-1906672-1.patch9.29 KB
roysegall’s picture

roysegall commented
StatusFileSize
new leftover-og-vocab-taxonomy-term-1906672-2.patch9.49 KB

I added a comment on the test.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Assigned: Unassigned » amitaibu

We are now taking a different approach using the Advanced-Queue module. Work is done in 1906672 branch.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
StatusFileSize
new 1906672-og-vocab-advanced-queue-4.patch9.23 KB

Haven't worked on the test yet, but the advanced-queue code seems to be working :)

roysegall’s picture

roysegall commented
StatusFileSize
new 1906672-og-vocab-advanced-queue-5.patch9.12 KB

The test of the advance queue is checking the delete of the OG vocabulary via the API ant not through UI.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Needs review » Needs work

Looks good:

+++ b/og_vocab.testundefined
@@ -478,3 +478,115 @@ class OgVocabApiTestCase extends DrupalWebTestCase {
+    // Create two groups type.
+    $this->setUpGroupContent('first');
+    $this->setUpGroupContent('second');

No need for the helper function. write the explicit code.

+++ b/og_vocab.testundefined
@@ -478,3 +478,115 @@ class OgVocabApiTestCase extends DrupalWebTestCase {
+      $this->assertTrue(!empty($node->{OG_VOCAB_FIELD}), 'Terms are attached to the node ' . $groups_content->title . '.');

Use format_string()

roysegall’s picture

roysegall commented
StatusFileSize
new 1906672-og-vocab-advanced-queue-7.patch9.36 KB
amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Needs work » Needs review
amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Needs review » Needs work 
+++ b/og_vocab.testundefined
@@ -478,3 +478,116 @@ class OgVocabApiTestCase extends DrupalWebTestCase {
+  private $first;

Better names.

+++ b/og_vocab.testundefined
@@ -478,3 +478,116 @@ class OgVocabApiTestCase extends DrupalWebTestCase {
+   * When a vocabulary is related to a bundle and his term are reference to the

his => its
him => it

+++ b/og_vocab.testundefined
@@ -478,3 +478,116 @@ class OgVocabApiTestCase extends DrupalWebTestCase {
+    // Creating the vocabulary.

=> Create

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Assigned: amitaibu » roysegall

Please fix #9 and commit.

roysegall’s picture

roysegall commented
Status: Needs work » Closed (fixed)

Apply fixes and committed.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Closed (fixed) » Fixed

Setting to correct status.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.