The issue comes, for example, when the connection is lost. It seems that the code doesn't test if the things goes all right. Just executes the code and return the message saying that the form was autosaved, even when there's no connection. And if so, the form wasn't really saved (dúh!).
A think that, at least, as a bottom module's functionality, it should warn users when the form doesn't really save, or it can be mislead. Worst of all for users when the tool says that it do something that it actually doesn't really do!

Comments

liquidcms’s picture

liquidcms commented

when first reading this i didn't see it as a big deal as i assumed the user would have only lost the "last" autosave; but i suppose the connection could be lost after initially editing the content and therefore it would continue to lose all the autosaves.

i would think that there would be an ajax error popup if the ajax send fails? is this not the case?

danilocgsilva’s picture

danilocgsilva commented

After lost connection, indeed, it lost only the last autosave. Just tested here.

An yes, pop an error message on a autosaving fail is exactly what I wonder as a "bottom module's functionality". And it's important, because I think that we still have lots places in world where the connection is not realiable. And when it is down, the greater probability, I think, is that it does not get reestablished in a short period of time, till it hit the save button and see that horrible browser message and notice that all those long form filling was lost. Just poping the error message would save these people from such frustration...

Thanks!

liquidcms’s picture

liquidcms commented
Status: Active » Postponed (maintainer needs more info)

hmm.. so you are saying there is an ajax error when connection is lost.. so only last save is missed.. if thats the case this really isn't an issue then.. not like we could prevent the connection from going down and they have likely only lost last 30 sec or so (depending on what AS interval is set to)

if this is all true then not really something i would bother to change; but if you wanted to submit a patch for this i would likely consider committing it.

danilocgsilva’s picture

danilocgsilva commented

No. The question isn't an ajax error, but it should have and ajax message warning about an error on connection an so, the form couldn't be saved.

The problem is not that only last save is missed, but all save is missed during the connection lost. The module can't solve the connection lost, but can say if something is wrong. It will always say that the form is saved, even in a connection lost.

What I think that the solution for this is just to test the connection before each saving. If it save the form successful, so it will return the usual message. But if couldn't, it will return a different ajax message, saying that the form wasn't saved.