Commerce Brazilian IDs

Hi,

first of all there are quite a few issues to sort out such as indentation, whitespace.

You can find them all here:
http://ventral.org/pareview/httpgitdrupalorgsandbox7links1907474git

Here you can check source code whether it meets drupal coding standards or not, and advise you what to change in your code. You can repeat review after your commits, and can fix those errors.

1) No README.txt file
2) Move your code to custom branch 7.x-1.x & delete master branch.
3) In repository your module file empty, just

Git command to delete branch:

1. git checkout 7.x-1.x
2. git branch -D master
3. git push origin :master

More information on http://drupal.org/node/1127732

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and put yourself on the PAReview: review bonus high priority list. Then I'll take a look at your project right away :-)

hi 7links,

I'm trying to download your module so I can test it, but the .module file is blank.

please let me know when you have something up so I can download it.

I can only test the CPF field, since I don't own a business. ;)

cheers,
Luciano

oh, I see! :)

your code is pretty neat; however, it creates fields in Portuguese.

I would advise you to use terms in English - not only because Drupal is written in English, but also because then other countries can benefit from your work. I'm pretty sure our country is not the only one to register citizens and businesses ;)

try this:
commerce_linha_digitavel -> commerce_manual_input
commerce_customer_cpf_cnpj -> commerce_customer_id
commerce_customer_insc_estadual -> commerce_customer_business_id

nevertheless, you must wrap all fields' labels and descriptions in t().

Your project page text also needs some revision. I can help with that.

over the weekend I'll try and download your module, see if it all works, and get back to you.

cheers,
Luciano

oh, ok. :)

maybe in the near future there could be a module that would check format for any ID, not just Brazillian ones... but that's another story.

well, I'm in no position to accept or deny your application, that's up to the good folks in this queue to decide. :) good luck.

7links,

here's a correction for the module's info file:
Create brazilian id fields on billing profile.

and where do I download the Brazilian IDs module?

cheers

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.