The user account setting "Receive email notification for incoming private messages" does not seem to save when changed. If the user checks it or unchecks it it always remains checked.

CommentFileSizeAuthor
#8 privatemsg-pm-email-notify-opt-out-1908188-8.patch968 bytesptmkenny
#7 privatemsg-pm-email-notify-opt-out-1908188-7.patch57.89 KBptmkenny
#5 privatemsg-pm-email-notify-opt-out-1908188-5.patch980 bytesptmkenny
#3 privatemsg-pm-email-notify-opt-out-1908188-3.patch1.09 KBkhu

Comments

gratefulsk’s picture

gratefulsk commented

Ok I jumped the gun. My permissions weren't set correctly. Sorry

Rory’s picture

Rory commented
Status: Active » Closed (fixed)
khu’s picture

khu commented
Priority: Major » Normal
Status: Closed (fixed) » Needs review
StatusFileSize
new privatemsg-pm-email-notify-opt-out-1908188-3.patch1.09 KB

Encountering the same issue. Users who are not given permission to modify level of email notification should still be able to opt out entirely if the default is not so.

The situation described by celticremark seems to be caused by the default value of the checkbox form element not properly checking for user setting.

Status: Needs review » Needs work

The last submitted patch, privatemsg-pm-email-notify-opt-out-1908188-3.patch, failed testing.

ptmkenny’s picture

ptmkenny commented
Status: Needs work » Needs review
StatusFileSize
new privatemsg-pm-email-notify-opt-out-1908188-5.patch980 bytes

Re-rolled #3 patch so that it can be applied by testbot.

Status: Needs review » Needs work

The last submitted patch, privatemsg-pm-email-notify-opt-out-1908188-5.patch, failed testing.

ptmkenny’s picture

ptmkenny commented
Status: Needs work » Needs review
StatusFileSize
new privatemsg-pm-email-notify-opt-out-1908188-7.patch57.89 KB

Re-rolling. I edited the last one manually so I missed a line. (Bad patch)

ptmkenny’s picture

ptmkenny commented
StatusFileSize
new privatemsg-pm-email-notify-opt-out-1908188-8.patch968 bytes

Ok, should be correct this time.

ptmkenny’s picture

ptmkenny commented
Issue summary: View changes
Related issues: +#1511398: pm_email_notify_user() does not handle users without the "set privatemsg e-mail notification level" permission properly
dgtlmoon’s picture

dgtlmoon commented

thanks, works for me

  • ptmkenny authored d56c261 on 7.x-2.x 
    Issue #1908188 by ptmkenny, khu: "Receive email notification for...
dgtlmoon’s picture

dgtlmoon commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.