Update edit modules implementation of hook_toolbar; refresh the design to match current mockups [#1908624]

The hook hook_toolbar was updated in #1847198-73: Update the structure returned by hook_toolbar().

With these changes, we can finally improve the design of the Edit mode toggle. Here is a screenshot with the updated toggle indicated by an arrow.

Screenshot of the updated Edit mode toggle design. The toggle is now floated to the right instead of the left.

Comment	File	Size	Author
#1	edit-toolbar-tab-on-the-right.png	5.31 KB	jessebeach
#1	edit-toolbar_1908624-1.patch	2.99 KB	jessebeach
	toolbar-edit-toggle-design-update.png	8.24 KB	jessebeach

Comments

Comment #1

jessebeach commented 5 February 2013 at 16:55

Status	File	Size
new	edit-toolbar_1908624-1.patch	2.99 KB
new	edit-toolbar-tab-on-the-right.png	5.31 KB

This patch floats the edit toolbar tab to the right.

It also removes some dead JavaScript and CSS code dealing with trays that was required by hook_toolbar's previous structure.

Screenshot of the toolbar showing the Edit tab floated to the right. It is flush with the right edge of the screen.

Comment #2

gábor hojtsy

he/him

Hungarian

Hungary

commented 6 February 2013 at 08:50

Status:

Active

» Reviewed & tested by the community

Looks good to me as a small next step :)

Comment #3

wim leers

Ghent 🇧🇪🇪🇺

commented 6 February 2013 at 09:55

Manually tested, works perfectly. RTBC +1

Comment #4

webchick

she/they

English

Vancouver 🇨🇦

commented 9 February 2013 at 00:17

Status:

Reviewed & tested by the community

» Fixed

Rock! Committed and pushed to 8.x.

Btw, I know this looks like an Acquia pig-pile atm ;), but this design direction has been discussed elsewhere as a good thing to do, since it's not a navigation element like everything else on the LH side.