Raising the PHP-bar is not a nice thing. Lots of sites depend on 5.2.

You already mention this in below code. It that the only location for PHP5.3?

/**
 * @TODO Compatible with PHP 5.3 and more only. Find a way for 5.2 compatibility.
 */
function _taxonomy_menu_flatten_form_settings($settings) {
  $flatten = array();
  array_walk_recursive($settings, function($a, $b) use (&$flatten) { $flatten[$b] = $a; });

  return $flatten;
}

Comments

hles’s picture

Version: 7.x-2.0-alpha2 » 7.x-2.x-dev

Yes this is the only location. It needs to be rewritten for PHP 5.2 before releasing the final 2.0 version. PHP version should be removed from .info file once this is done.

johnv’s picture

Status: Active » Needs review
StatusFileSize
new1.05 KB

See attached patch.
Line numbers are not correct, due to the other patch I am working on.

hles’s picture

Status: Needs review » Needs work

Thank you johnv.
Some trailing white spaces, coding standards for comments and the PHP 5.3 requirement in .info file and this is good to go.

johnv’s picture

Any more details on the comments?

johnv’s picture

Status: Needs work » Needs review
StatusFileSize
new1.41 KB
hles’s picture

Status: Needs review » Reviewed & tested by the community

Thank you ! I'll commit this ASAP.

hles’s picture

Title: Dependency on PHP 5.3 ? » Remove dependency on PHP 5.3
Status: Reviewed & tested by the community » Fixed

Committed with minor formatting changes 3755dfe. Thank you !

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.