Hello!

here is some problem

after installation of the module climbs this error

Recoverable fatal error: Argument 2 passed to metatag_filter_values_from_defaults() must be an array, null given, called in /sites/all/modules/metatag/metatag.module on line 870 and defined в функции metatag_filter_values_from_defaults() (строка 1416 в файле /sites/all/modules/metatag/metatag.module).

when saving node

thanks for answer)

CommentFileSizeAuthor
#3 metatag-n1909224-3.patch713 bytesdamienmckenna
#2 1909224-metatag-fatal-error-on-node-save.patch539 bytesdjdevin

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Postponed (maintainer needs more info)

Does it still happen with the latest -dev release?

djdevin’s picture

djdevin
he/him
Primary language English
Location Philadelphia
commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new 1909224-metatag-fatal-error-on-node-save.patch539 bytes

Yes this still happens - for me it is when the Metatag fields have #access = FALSE from something like Multistep or another form manipulator. Seems like an edge case, but other fields handle it fine.

Patch attached but I don't know the effects of it, it makes sure there are actually posted values coming in before calling that function. Metatags still seem to be saving fine.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n1909224-3.patch713 bytes

How about this instead?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed, thanks for catching the bug.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Fixed » Closed (fixed)

1.0-beta6 is out, so I'm closing this issue in the interest of keeping the issue queue clean.