Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
7 Feb 2013 at 14:30 UTC
Updated:
28 Apr 2013 at 04:25 UTC
The HyperComments technology replaces your Drupal comment system with your comments hosted and powered by HyperComments
module for Drupal 7
HyperComments Features
HyperComments module for Drupal
1) SSO
2) Export Comments
3) Synchronization comments
git clone http://git.drupal.org/sandbox/hypercomments/1910684.git hypercomments
| Comment | File | Size | Author |
|---|---|---|---|
| screenshot-3.png | 199.94 KB | hypercomments | |
| screenshot-2.png | 60.22 KB | hypercomments | |
| screenshot-1.png | 9.41 KB | hypercomments |
Comments
Comment #1
vaibhavjainWelcome hypercomments to the community.
Automated review of your module
http://ventral.org/pareview/httpgitdrupalorgsandboxhypercomments1910684git
There are some issues, please fix them.
Manual Review.
Info file is incomplete - Required attributes are missing, Please check here for more details - http://drupal.org/node/542202
Module File - Function hypercomments_seo()
Can you use a theme function rather than direct output, this would be much cleaner, as all HTML is supposed to be in a TPL file.
BIGGER reason being that closing php tags "?>" in a module file is a BIG NO NO in drupal.
admin.inc File - Function hypercomments_admin_savewid()
Rather than using json_encode, you can use drupal_json, and remove exit.
There are similar issues as above 2 in this module. Please work on them
Comment #2
hypercomments commentedFix bugs
Comment #3
klausiWe are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)
Priority is normal, see http://drupal.org/node/539608
Comment #4
dDoak commentedHi,
Please add a Readme.txt to your module.
A quick manual review :
- bad indentation in hypercomments_help
- get_language, get_auth do not respect naming standard (must be prefixed by module name)
- in hypercomments.js encapuslate your JQuery code in "(function ($) { })(jQuery); and use $ instead of JQuery.
- in hypercomments_admin_notify use $_POST instead of $_REQUEST
- in hypercomments_admin_delete_xml use conf_path() function to generate your xml file path
Thx
Comment #5
joshhoegen commentedI love the concept and see huge potential, but I'm having a hard time getting this ball rolling after installation. Can we get a read me?
Also, I'm still seeing a lot of errors in the automatic code review:
http://ventral.org/pareview/httpgitdrupalorgsandboxhypercomments1910684git
Comment #6
PA robot commentedClosing due to lack of activity. Feel free to reopen if you are still working on this application.
I'm a robot and this is an automated message from Project Applications Scraper.