Could be nice having some integration with Workflow-ng module.
This will allow also non-developers to create a proper workflow for adding/ removing nodes from the nodequeue.

CommentFileSizeAuthor
#8 nodequeue_rules_3.patch10.09 KBamitaibu
#7 nodequeue_rules_2a.patch5.4 KBjcarney
#6 nodequeue_rules_2.patch10 KBamitaibu
#5 wfng_nodequeue_1.patch9.75 KBamitaibu
#5 Snap1.png4.37 KBamitaibu
#5 wf_ng.txt5.4 KBamitaibu

Comments

merlinofchaos’s picture

merlinofchaos commented

Nodequeue has actions integration for purposes like this. Does workflow-ng eschew actions? Would something else have to be done?

I've never really looked at workflow-ng so I'm probably not likely the person to do integration, but if a decent patch came in I'd consider it.

peterpoe’s picture

peterpoe commented

I think that actions in workflow_ng are different from actions in actions module.

But you can obtain this by following these steps:
- create your nodequeue
- configure a nodequeue action
- find the newly created action id (it's the last argument of the path to the configuration page of the action, e.g.: /admin/build/actions/config/1)
- create a new workflow_ng rule
- as a rule action, use 'Execute custom PHP code'
- the custom PHP code is: actions_do(ACTION_ID_HERE, $node);

moshe weitzman’s picture

moshe weitzman commented

The D6 version of NG is being renamed rules engine and does re-use actions. or so i hear from fago.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

just an FYI, I have already started working on integration of WF-ng for D5 (which includes also conditions). When I am back from my travels (in about 3 weeks) I will submit a patch.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Active » Needs review
StatusFileSize
new wf_ng.txt5.4 KB
new Snap1.png4.37 KB
new wfng_nodequeue_1.patch9.75 KB

This patch adds 4 actions:
1. Load existing nodequeue
2. Create (and load) new nodequeue.
3. Add node to nodequeue.
4. Remove node from nodequeue.

Suggestion how to test:
1. Enable custom content links (CCL) from the wf_ng package.
2. Create custom links like in snap1.png
3. Import the wf_ng.txt to workflow_ng.
4. Assign the actions to CCL. So every time a CCL is clicked an event is triggered.

I am not a native speaker, so please review also my grammar :)

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
StatusFileSize
new nodequeue_rules_2.patch10 KB

Some fixes to Load action.

jcarney’s picture

jcarney commented
StatusFileSize
new nodequeue_rules_2a.patch5.4 KB

I've checked the the patch and tested the load nodequeue and add node actions. It all looks good, apart from one potentially serious typo - "reverese" instead of "reverse". I've fixed that, tidied up a few non-critical spelling errors and clarified the titles and descriptions of the load nodequeue form fields. All included in the attached patch, which must be applied AFTER patch #2 above.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
StatusFileSize
new nodequeue_rules_3.patch10.09 KB

@jcarney,
Thank you for the review and patch

I've created a single patch with functionality and jcarney's reverse and typo fix (I've omitted the change in line breakings in t() as it is also used in core)

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Committed to DRUPAL-5--2 -- leaving this one out of HEAD for the moment since it appears there may be interesting changes afoot for D6.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.