Problem/Motivation

The Ubercart Addresses Example module currently has combined the field definitions for the Schema API and the field definitions for the Ubercart Addresses field handler API in one function. This leads to problems in #1910626: Ubercart Addresses field handler API: Fields should specify their data type, where a 'type' property is introduced in the field definitions for Ubercart Addresses.

Proposed resolution

Separate the field definitions. Define the field definitions for the Schema API in one function and the field definitions for the Ubercart Addresses field handler API in an other.

Remaining tasks

  • Implement the proposed resolution.
  • Adjust the documentation (the included README-file).

User interface changes

None.

API changes

None.

A patch will follow.

Comments

megachriz’s picture

Status: Active » Needs review
StatusFileSize
new9.26 KB

The attached patch implements the proposed resolution and adjusts the README-file. I have not tested the code yet.

megachriz’s picture

Version: 7.x-1.x-dev » 6.x-2.x-dev
Status: Needs review » Patch (to be ported)

committed #1.

Needs backport to 6.x-2.x.

megachriz’s picture

Status: Patch (to be ported) » Needs review
StatusFileSize
new9.45 KB

Patch for the 6.x-2.x version. This is nearly the same as the patch for the 7.x-1.x version in #1.

megachriz’s picture

Version: 6.x-2.x-dev » 7.x-1.x-dev
Status: Needs review » Fixed

Committed #3.

Setting version back to the one the issue was originally reported for and mark this issue as fixed.

megachriz’s picture

I made some small corrections to 7.x-1.x version of the example module that were included in the fix for the 6.x-2.x version, but not in the 7.x-1.x version. Now the example module should be consistent between to the two versions again.

See the commit.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.