Safari version 2.0.4
Mac 10.4.10

Using either the release version (5.x-1.1) or Dev version (5.x-1.x-dev, 2007-Nov-03) the second level of menus are misaligned and are unreachable. They are aligned with the lower menu item. Please see screenshot. There is no problem with Mac FF, Windows IE7, Windows Opera 9.23. No, only the browser I use most of the time. :-(

Comments

sun’s picture

I remember experiencing this bug with SuckerFish dropdowns a while ago. I somehow fixed it in the stylesheet, but I'm not able to recall how today. I only know that it was related to a really weird style definition. Let's try this:

Could you try to remove or comment out all instances of

font-weight: bold;

in admin_menu.css?

okeedoak’s picture

Commented out all (2) instances of font-weight: bold; but no difference. Sorry. Any other ideas?

Rob T’s picture

I have the same problem in Safari. An older version of this module from May 2007 worked fine.

Rob T’s picture

FYI... I just replaced the admin_menu.css file with my old one from the March 30th (5.x) build.

Seems to be working OK. Definitely better than the misaligned, newer version of the css. If I run into any major issues, I'll report back.

okeedoak’s picture

They seem to be exactly the same?!

Could you post a copy of the one that works please?

sun’s picture

StatusFileSize
new5.08 KB

Attached is a diff between admin_menu.css rev. 1.7 and the latest version. While the diff contains all changes, I'll outline those that may have caused this issue:

 /* all lists */
+#admin_menu ul { position: static; }

AFAIK, added for IE7 support.

 /* all lists */
-#admin_menu a { ... padding: 4px 7px; ... }
+#admin_menu ul a { ... border-bottom: none; padding: 4px 8px; ... text-align: left; }

AFAIK, added to support various themes (border/text-align) and better readability (padding).

 /* all list items */
 /* width needed or else Opera goes nuts */
-#admin_menu li { ... }
+#admin_menu li { ... height: 100%; ... }

AFAIK, added for IE7 support (very strange behaviour).

I hope this helps.

okeedoak’s picture

I downloaded a fresh 5.x-1.2 Official release and ran the patch using: patch admin_menu.css admin_menu.css_.diff
and this was the result:
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 32.
2 out of 2 hunks FAILED -- saving rejects to file admin_menu.css.rej

What did I do wrong?

This is probably obvious but Safari isn't respecting #admin_menu li li.expandable ul {} for some reason...

sun’s picture

@okeedoak: The .diff file provided in #6 was not a patch to solve this issue. It was a diff to outline all changes since March up to now. You may use this information to debug, if one of the mentioned styles are the cause for the misalignment of second level menus in Safari.

Rob T’s picture

http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/admin_menu/...

I used Rev. 1.7.4.1 of admin_menu.css.

Like I stated, this was the only file I replaced, and it works for me in Safari.

sun’s picture

Version: 5.x-1.x-dev » 5.x-1.2

Thanks for clarifying this once more. However, we need to know what exactly causes Safari to misalign second level menu items, because there have been many CSS bugs fixed since 1.7.4.1. That was the reason why I outlined all possibly related changes in #6.

Did you also try later versions? If you could check them, we might be able to narrow the guilty styles down.

Standart’s picture

Title: Safari misalignment of second level menus » Misalignment of second level menus in Safari 2

Safari 3.0.4 (Mac OS X 10.4.11) does not have this issue.

sun’s picture

I don't have a Mac. So I don't know if we can still consider this a bug (compare it to issues related to IE v6 / 7) or if users can simply upgrade their browsers (compared to issues related to Firefox v1 / 2).

okeedoak’s picture

http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/admin_menu/...

I used Rev. 1.7.4.1 of admin_menu.css.

Like I stated, this was the only file I replaced, and it works for me in Safari.

Yes indeed, this does work! Thank you!

okeedoak’s picture

I don't have a Mac. So I don't know if we can still consider this a bug (compare it to issues related to IE v6 / 7) or if users can simply upgrade their browsers (compared to issues related to Firefox v1 / 2).

I've tried some basic debugging in comparing the two different css files (the old one that works and the current one that doesn't) in the hope of finding the magic line(s) that causes the problem but I haven't been successful. Even if I was to find the necessary change I wouldn't know what consequence the change might bring to other browsers.

I'd say that this is still a bug, but a minor one with two possible workarounds:

  1. Use the older css file
  2. Upgrade to Safari 3 (Which I will do in the next few days.)

Part of me doesn't like letting it go like this but I think the workarounds are acceptable and I do have more important things to do. Thank you all for your help on this.

sun’s picture

Title: Misalignment of second level menus in Safari 2 » Safari 2.x: Misalignment of 2nd level menus

I'll keep this issue open for a while. If someone discovers the style that is causing this bug, please let me know.

Adding yourself by posting a "subscribing" (or the like) won't hurt, too, because I have absolutely no idea of how many Safari 2.x users are experiencing this bug.

sirkitree’s picture

Version: 5.x-1.2 » 5.x-2.2

I just took out the height:100% on the #admin_menu li and it seems to have solved this.

sun’s picture

Title: Safari 2.x: Misalignment of 2nd level menus » IE7/Safari 2.x: Misalignment of 2nd level menus
Assigned: Unassigned » sun
Status: Active » Needs review
StatusFileSize
new840 bytes

Ok, so attached patch should fix this issue for Safari.

However, height: 100%; has been added to fix exactly the same bug in IE7. Thus, I need someone having access to IE7 to confirm that this patch does not break it again for IE7.

Standart’s picture

Status: Needs review » Needs work

I tried with IE7 and drop-downs are not working at all anymore.

IE7, Windows Vista,
Drupal 5.7
Admin Menu 5.x-2.3 + patch #17

sun’s picture

StatusFileSize
new912 bytes

omg, we have missed to rename CSS ids in admin_menu.js.
@Standart: Could you please test attached patch which should fix IE-support in 5.x-2.3?

Standart’s picture

Version: 5.x-2.2 » 5.x-2.3
StatusFileSize
new10.2 KB

Attached is a screenshot of IE6 with patch #19 (not patch #17).

A similar effect happens in IE7 with patch #19 AND patch #17 (without patch #17 it's ok).

sun’s picture

Status: Needs work » Needs review

IE-related bugs in 5.x-2.3 have been fixed. Please update to 5.x-2.4.

Resuming normal operations. Patch in #17 needs review from both IE7 and Safari 2 users.

sun’s picture

Status: Needs review » Fixed

No replies - seems like #17 is no longer needed. Feel free to re-open this issue if you don't think so.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.