Closed (fixed)
Project:
Administration menu
Version:
5.x-2.3
Component:
CSS / Browser Support
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
10 Nov 2007 at 21:30 UTC
Updated:
20 Apr 2008 at 15:21 UTC
Jump to comment: Most recent file
Comments
Comment #1
sunI remember experiencing this bug with SuckerFish dropdowns a while ago. I somehow fixed it in the stylesheet, but I'm not able to recall how today. I only know that it was related to a really weird style definition. Let's try this:
Could you try to remove or comment out all instances of
in admin_menu.css?
Comment #2
okeedoak commentedCommented out all (2) instances of font-weight: bold; but no difference. Sorry. Any other ideas?
Comment #3
Rob T commentedI have the same problem in Safari. An older version of this module from May 2007 worked fine.
Comment #4
Rob T commentedFYI... I just replaced the admin_menu.css file with my old one from the March 30th (5.x) build.
Seems to be working OK. Definitely better than the misaligned, newer version of the css. If I run into any major issues, I'll report back.
Comment #5
okeedoak commentedThey seem to be exactly the same?!
Could you post a copy of the one that works please?
Comment #6
sunAttached is a diff between admin_menu.css rev. 1.7 and the latest version. While the diff contains all changes, I'll outline those that may have caused this issue:
AFAIK, added for IE7 support.
AFAIK, added to support various themes (border/text-align) and better readability (padding).
AFAIK, added for IE7 support (very strange behaviour).
I hope this helps.
Comment #7
okeedoak commentedI downloaded a fresh 5.x-1.2 Official release and ran the patch using: patch admin_menu.css admin_menu.css_.diff
and this was the result:
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 32.
2 out of 2 hunks FAILED -- saving rejects to file admin_menu.css.rej
What did I do wrong?
This is probably obvious but Safari isn't respecting #admin_menu li li.expandable ul {} for some reason...
Comment #8
sun@okeedoak: The .diff file provided in #6 was not a patch to solve this issue. It was a diff to outline all changes since March up to now. You may use this information to debug, if one of the mentioned styles are the cause for the misalignment of second level menus in Safari.
Comment #9
Rob T commentedhttp://cvs.drupal.org/viewvc.py/drupal/contributions/modules/admin_menu/...
I used Rev. 1.7.4.1 of admin_menu.css.
Like I stated, this was the only file I replaced, and it works for me in Safari.
Comment #10
sunThanks for clarifying this once more. However, we need to know what exactly causes Safari to misalign second level menu items, because there have been many CSS bugs fixed since 1.7.4.1. That was the reason why I outlined all possibly related changes in #6.
Did you also try later versions? If you could check them, we might be able to narrow the guilty styles down.
Comment #11
Standart commentedSafari 3.0.4 (Mac OS X 10.4.11) does not have this issue.
Comment #12
sunI don't have a Mac. So I don't know if we can still consider this a bug (compare it to issues related to IE v6 / 7) or if users can simply upgrade their browsers (compared to issues related to Firefox v1 / 2).
Comment #13
okeedoak commentedYes indeed, this does work! Thank you!
Comment #14
okeedoak commentedI've tried some basic debugging in comparing the two different css files (the old one that works and the current one that doesn't) in the hope of finding the magic line(s) that causes the problem but I haven't been successful. Even if I was to find the necessary change I wouldn't know what consequence the change might bring to other browsers.
I'd say that this is still a bug, but a minor one with two possible workarounds:
Part of me doesn't like letting it go like this but I think the workarounds are acceptable and I do have more important things to do. Thank you all for your help on this.
Comment #15
sunI'll keep this issue open for a while. If someone discovers the style that is causing this bug, please let me know.
Adding yourself by posting a "subscribing" (or the like) won't hurt, too, because I have absolutely no idea of how many Safari 2.x users are experiencing this bug.
Comment #16
sirkitree commentedI just took out the height:100% on the #admin_menu li and it seems to have solved this.
Comment #17
sunOk, so attached patch should fix this issue for Safari.
However,
height: 100%;has been added to fix exactly the same bug in IE7. Thus, I need someone having access to IE7 to confirm that this patch does not break it again for IE7.Comment #18
Standart commentedI tried with IE7 and drop-downs are not working at all anymore.
IE7, Windows Vista,
Drupal 5.7
Admin Menu 5.x-2.3 + patch #17
Comment #19
sunomg, we have missed to rename CSS ids in admin_menu.js.
@Standart: Could you please test attached patch which should fix IE-support in 5.x-2.3?
Comment #20
Standart commentedAttached is a screenshot of IE6 with patch #19 (not patch #17).
A similar effect happens in IE7 with patch #19 AND patch #17 (without patch #17 it's ok).
Comment #21
sunIE-related bugs in 5.x-2.3 have been fixed. Please update to 5.x-2.4.
Resuming normal operations. Patch in #17 needs review from both IE7 and Safari 2 users.
Comment #22
sunNo replies - seems like #17 is no longer needed. Feel free to re-open this issue if you don't think so.
Comment #23
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.