Attached patch restricts content to the specified domain regardless of the user's permissions.

It does so by forcing a JOIN on {node_access} that introduces an AND clause to the WHERE.

Two questions:

1) Does the patch work? That is, does it break anything?

2) Does the patch work as desired?

CommentFileSizeAuthor
#3 domain_content3.patch1.51 KBagentrickard
#1 domain_content.patch1.25 KBagentrickard
domain_content.patch1.41 KBagentrickard

Comments

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
StatusFileSize
new domain_content.patch1.25 KB

Last patch had two typos and a stuff function. Fixed.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Needs review
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
StatusFileSize
new domain_content3.patch1.51 KB

For users that invoke node access checks, we have to use a different table prefix in our join statement.

derjochenmeyer’s picture

derjochenmeyer commented

In my sandbox it didnt break anything

Works as desired. :)

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

I think the question is: on one.example.com, do we show posts assigned just to that domain, or to that domain plus 'all affiliates'?

But I think that has been answered correctly by this patch. Show 'all affiliates' as a separate link.

derjochenmeyer’s picture

derjochenmeyer commented

yes, it just works as expected, very intuitve.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Reviewed & tested by the community

And, notice, it doesn't interfere with db_rewrite_sql(), so it isn't a hack.

RTBC.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Reviewed & tested by the community » Closed (fixed)

Committed to HEAD.