foreach($field['settings']['handler_settings']['target_bundles'] as $target_entity => $target_bundle) {

This is completely wrong. The target bundles array of an entityref field's settings is of the form:

array(
  bundleA => bundleA,
  bundleB => bundleB,
)

There are no entity types involved, as an entref field can only point to one entity type.

The $target_entity and $target_bundle loop variables are used several times in this loop; I'm not sure yet exactly what the consequences are...

CommentFileSizeAuthor
#3 1911798.services_entity.field-settings-resource-name-target-entity.patch10.14 KBjoachim

Comments

joachim’s picture

joachim commented

Ah, the first problem will be that the resource won't get created properly:

            $resources["entity_$target_entity"]['relationships'][$name] = array(

because $target_entity is a bundle name. This will only work with entities with a single bundle that has the same name as the entity.

joachim’s picture

joachim commented

This takes some figuring out:

          foreach($field['settings']['handler_settings']['target_bundles'] as $target_entity => $target_bundle) {
            $name = services_entityreference_format_plural($entity_type);
            $resources["entity_$target_entity"]['relationships'][$name] = array(

We're acting on each bundle the field points to. $target_entity is each bundle name, and so the resource setting will fail. $entity_type is the entity this field is on.

So what we're trying to do is add to the target entity a resource of the entities that point to it.

Problem is the target entity is the wrong variable.

Also, why are we looping on bundles, if it's to clobber the resource each time?

joachim’s picture

joachim commented
Status: Active » Needs review
StatusFileSize
new 1911798.services_entity.field-settings-resource-name-target-entity.patch10.14 KB

Here's a patch.

I've removed the loop on target bundles, since:

a) it doesn't appear to serve any purpose, as the bundle name isn't used, and $target_entity which is really the bundle name won't create valid resources
b) it's the source of another bug: that if the entref field has NO bundles selected, to indicate that all are valid, no resource is created at all.

Note that this patch, while fixing THIS problem, now exposes another: #1911810: multiple fields from one entity type to another clobber the resource.

joachim’s picture

joachim commented
Status: Needs review » Fixed

I contacted the other maintainer last week to ask for a review of this, but looking at it again, I'm sure this is the right thing to do -- it just doesn't make sense as it is (unless your entities are single-bundled, and the bundle has the same name as the entity!).

Also, it's holding up #1936472: create forward Services relationships for entityref fields as well as backwards :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.