On the "Review order" page, the sort order of fields within the fieldgroup pane doesn't match what's defined on the "Order settings -> Manage display" page.

CommentFileSizeAuthor
#3 1912326-field-display-order-incorrect-2.patch946 bytesznerol
#1 1912326-1.patch1.13 KBjrb

Comments

jrb’s picture

jrb
he/him
Primary language English
Location Raleigh-Durham Area, NC, USA
commented
Status: Active » Needs review
StatusFileSize
new 1912326-1.patch1.13 KB

The attached patch fixes the sort problem.

fietserwin’s picture

fietserwin
Location Le Mont-Dore
commented
Version: 7.x-1.0 » 7.x-1.x-dev
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

I ran into the same problem and can confirm that the patch does solve the problem. The weight assignment can be optimized a bit, but that's also a matter of coding preferences and can be changed by the module maintainer to is own preferences. so, please commit.

znerol’s picture

znerol commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 1912326-field-display-order-incorrect-2.patch946 bytes

There is no need to manually extract the weight from the field instance, field_view_field actually adds an appropriate '#weight' key. However this only takes effect when all fields are rendered together in one call to drupal_render.

fietserwin’s picture

fietserwin
Location Le Mont-Dore
commented
Status: Needs review » Reviewed & tested by the community

Great, this is so much better. I tested this patch and it works as expected: RTBC.

jfarry’s picture

jfarry commented

Also tested this. Works great :)

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Sweet, thanks @znerol

watergate’s picture

watergate commented

Simple, but effective. Thanks for the patch!

  • pcambra committed 6b9d0b7 on 7.x-1.x authored by znerol 
    Issue #1912326 by jrb, znerol: Field display order incorrect on "Review...
pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Reviewed & tested by the community » Fixed

Great solution @znerol, thanks for the patch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.