Posted by mlncn on November 11, 2007 at 2:29pm
Jump to:
| Project: | Localization client |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | support request |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (won't fix) |
Issue Summary
Can the updated version with live search be released? (Drupal 6 dev has an Oct. 30 release date, but Drupal 5 dev has Oct. 5 which is even earlier than Drupal 5 official release.)
Sort-of-related questions:
* For user #1, at least, all sorts of strings come up that are not on the page being viewed. Is this a known bug/feature?
* Are menus not translated through this interface? Even though the original comes from a t() ?
* Are t('text') in theme files not translated?
Thanks very much,
Comments
#1
Eh, we can fork this issue into a few other issues, or discuss four things here... Heh.
1. Jose A Reyero got maintainership on the Drupal 5 branch and he does the backports. Reach him at www.drupal.org/user/4299
2. Not all strings *used to build the page* are displayed on the page. Theme region names might appear for example (used in the theme). Basically anything, which was t()-ed in the program code to generate this page view is in the list. We don't know whether those actually ended up on the interface.
3. Menus are cached in Drupal 5 and only translated once, when cached.
4. They are translated. Maybe you mean they don't appear on the l10n_client interface?
#2
I should have been more clear about the common theme: when I am logged in as user #1 (not sure if this matters, I apologize for not testing more but we're in rapid development on everything), I see way more strings than I would expect for the page, and don't see some that I would expect.
1. Done!
2. See intro to this comment. And it would appear t()s from the theme level do not show up in the l10n_client interface (see 3).
3. [Totally offtopic.] Menu translation is totally different, isn't it? Are there export tools for it? We're dealing with more than a dozen languages.
4. On http://dev.wsf2008.net the "WORLD SOCIAL FORUM 2008 - another world is possible" is a t()'d string in the theme-- but I don't find it on the list (but we don't have search yet).
#3
I don't think the "common theme" matters here, these are different issues.
1. Great.
2. You did not give any examples so far. I have no idea what are you talking about here.
3. If the text goes through t(), it can be done on this interface, but it needs to go through t() *when the page is built*, to show up on the interface. If you built your menus with the Drupal core module, and added custom menu items, those are not going through t(), so they are not translatable. Built-in menu items however are translatable but cached, so they are not going through t() in each page call in Drupal 5. Again, this is a separate issue, depending on what you are looking for.
4. Oh, I looked this up in the Drupal 5 core code, and it seems to be right. So l10n_client uses hook_footer() which is the last time we can add output to the theme, but unfortunately Drupal 5 does not fill in this variable last when building the variable list for phptemplate themes. In fact it build it quite early, as "theme_closure" does the code building and "closure" is early in the alphabet. Heh. We fixed this in Drupal 6 core quite some time ago, but Drupal 5 is how it is, so the l10n_client patch for Drupal 5 should probably include a change to move the theme('closure') call in phptemplate.engine down the list. Again, as this is a separate issue, please open a new issue for this, copy this background info there, and get Jose include this fix in the patch. In the meantime, you can do it yourself, and move the theme('closure') to be the last list item in the code, you will see.
#4
1. Waiting for Jose.
2. Administrative strings on a public page, strings that belong to different pages. I'll get specific examples.
3. Thank you, that is clear.
4. Created issue: "Change order of theme calls in Drupal 5 to expose translations to i18n_client (DIY patch for Drupal 5)" -- http://drupal.org/node/191537 -- Should I create a patch, or not since it should be unified with the other patch?
#5
3. For the built-in menu items, l10n_client for Drupal 5 could include a menu_rebuild() call in hook_init() or something similar, so the menus are always there to translate, but then *all* menu items would end up on the page, not only the visible ones, but strings from the whole tree. So I am not sure that would be an enhancement.
#6
Anyone in contact with Jose A Reyero? I sent an inquiry through his contact form.
The latest backport would be fantastic for World Social Forum.
#7
Waiting for Jose.
We'll knock this down to normal priority in a week, when it won't really matter to World Social Forum anymore.
Is this secondary backport something a mere mortal could try?
#8
I don't know I never looked at the actual diff of the 6.x and 5.x versions. It might or might not depend on the jquery version used also. Unfortunately I cannot be of much help here, sorry.
#9
Hi, I see some 'waiting for me' messages here, but I cant see which are the pending questions. I guess some of the issues here have been addressed in the latest releases.
About the menus, try using the menu administration page for translating, all items should display there.
#10
The live search feature from the D6 was not backported at the time of the issue being submitted. (I did not check the D5 version since then, so I don't know whether it is done now).
#11
I will try the Jan 4 dev release of the D5 backport to see if the live search feature is in.
#12
I had no trouble running the 6x version on a Drupal 5.10
#13
It would be interesting to attempt to pop in the current D6 version in D5 and see whether it works. We are about to discontinue D5 support, but if this works out, we could do a quick D5 release with relatively complete features. I'm afraid with the updates since 2008 September, we might also require jquery_update et. al. So it might not turn out as simple. Anyone would like to help try? :)
#14