This is a follow up from #1911688: Change test group of entity reference SelectionTest.

"Views Modules" is a weird name for this grouping. Could we get a follow-up to rename that to something else, like maybe "Views Module Integration" or similar?

I think that name is pretty good, but suggestions are welcome. We can also remove the capitalisation abuse? i.e. 'Views module integration'.

This is a good novice task.

CommentFileSizeAuthor
#3 rename-views-modules-1912748-1.patch16.95 KBsamhassell

Comments

dawehner’s picture

dawehner
Primary language German
commented

Maybe we should try to describe a bit more that this are tests for the integration of modules with views and not views with these modules,
but I'm not native and good with everything :)

damiankloip’s picture

damiankloip commented

suggestions are welcome

:)

I'm open to changing this to whatever... I can't think of anything good right now though.

samhassell’s picture

samhassell commented
Status: Active » Needs review
StatusFileSize
new rename-views-modules-1912748-1.patch16.95 KB

went with 'Views module integration'

Its hard to think of a better name coz this group covers testing lots of different Views "thingies". Like displays, relationships, filters etc.

ao5357’s picture

ao5357 commented

I applied this patch and there was a group "Views module integration" but not "View Modules", so everything seems good.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

It's already an improvement, so go!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Looks great, thanks! :D

Committed and pushed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.