This module provides integration between Facebook Oauth and
Services. You will find this most useful if you're developing
an iOS Mobile Application, Android App or HTML5 Mobile App with PhoneGap.

Project page: http://drupal.org/sandbox/utneon/1903856

git clone --recursive --branch master utneon@git.drupal.org:sandbox/utneon/1903856.git

Currently only available for Drupal 7.

Comments

aw030’s picture

aw030 commented

Review:

*Automated review: not passed without errors...

FILE: /var/www/drupal-7-pareview/pareview_temp/README.txt
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AND 2 WARNING(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
...
...
...
--------------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/fboauth_services.info
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
...
--------------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/fboauth_services.module
--------------------------------------------------------------------------------
FOUND 15 ERROR(S) AFFECTING 13 LINE(S)
--------------------------------------------------------------------------------
...
...
...
--------------------------------------------------------------------------------

*Manual review:

- Install a fresh drupal 7 (localhost)
- Move the module folder to sites/all/modules
- Install required modules (ctools/services/fboauth)
- Install module
- go to /admin/structure/services
- Result as expected.

-------------------
tips:
- You must move from a master branch to a version branch
- LICENSE.txt must be removed
- "version" from the ./fboauth_services.info file must be removed

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

utneon’s picture

utneon commented

I will help with that later, I'm currently very busy developing modules for Drupal solutions and I will update the modules I'm submitting as soon as possible as my contribution. I'm going to release a very interesting new module in a few minutes which is working just fine but may need some help reviewing. I will post it for review anyway. Thank you very much for your review and feedback!

Anonymous’s picture

Anonymous (not verified) commented

Manual code review:

  • remove version descriptor in .info file
  • remove LICENSE.txt file
  • line 38: I'd rather use the built-in functionif(user_is_logged_in()) to perform the check. Just to adhere to existing functions... :)

Keep up the good work!

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxutneon1903856git

PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

gregoiremotot’s picture

gregoiremotot commented
Issue summary: View changes

I had problem with email.
When I try to register on /[endpoint]/fboauth/connect with fb access_token, I didn't get email of user.

POST :
/[endpoint]/fboauth/connect
params :
access_token = "CA...LZC"

To fix it :

I change in file fboauth_services.module (line 52) :
$fbuser = fboauth_graph_query('me', $access_token);
to
$fbuser = fboauth_graph_query('me?fields=id,name,email', $access_token);

after I get email when I register.

On more tips, you need to put fboauth_services.module and fboauth_services.info in folder fboauth

Thanks for this module ! :)