One of the messages at node _pathauto_bulkupdate() is not using _pathauto_verbose() wrapper. Then the message is always shown, and it does not any check.

This bug does not seem to affect 7.x-1.x or 6.x-2.x, so I'm providing a patch for 6.x-1.x

CommentFileSizeAuthor
#1 0001-Issue-1913020-by-marvil07-Fixed-Generation-message-n.patch877 bytesmarvil07

Comments

marvil07’s picture

marvil07 commented
Assigned: marvil07 » Unassigned
Status: Active » Needs review
StatusFileSize
new 0001-Issue-1913020-by-marvil07-Fixed-Generation-message-n.patch877 bytes
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Postponed (maintainer needs more info)

None of the _bulkupdate() functions check the verbose setting. This is because these code paths are only triggered from a specific admin action for Pathauto, it's ok to always show the message. The verbose setting is more for what happens when an URL alias changes for individual things where it may not be apparent that Pathauto is actually doing something.

So why do we need this?

marvil07’s picture

marvil07 commented
Status: Postponed (maintainer needs more info) » Active

I see, then I guess node_pathauto_bulkupdate() should not be called manually, right? (that's why I end up on that).

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

It's intended to be used as a batch API callback by Pathauto, so yes this is a little unanticipated to be called directly.

mably’s picture

mably commented
Issue summary: View changes
Status: Active » Closed (outdated)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.