Adding a link to reload the page on installation error
xmacinfo - November 11, 2007 - 20:44
| Project: | Drupal |
| Version: | 6.x-dev |
| Component: | install system |
| Category: | task |
| Priority: | normal |
| Assigned: | xmacinfo |
| Status: | closed |
Description
While installing Drupal head my site directory permission were not set correctly.
Once fixing the issue, I notice that the GUI did not offer a button to reload the page.
So I added a link, with the help of webchick, to reload the page.
| Attachment | Size |
|---|---|
| reloadinstall.patch | 963 bytes |
#2
I recreated the error (on my test site, I changed the ownership of sites/default to root and made sure it was not writable) and the patch gave me the "reload page" link as expected.
However as I was trying different things to get errors on the install page one thing I did was add a non-existent module to the default profile (e.g. edit profiles/default/default.profile and added 'boo' to the list of modules.) When I got the "required modules are missing" error, it already has a "try again" link that uses different text from this patch. Also, the "reload page" that this patch adds was between the set message box and the "reload page" link which is quite odd looking. See the attached screenshot for a clearer picture. ;-)
#3
oops, cnw
#4
Thanks add1sun for the comments and review.
I'm including a patch that fixes both of these issues.
#5
Awesome! Now it gives just one standardized "try again" message for both the writable sites/default and the required modules error. Looks good to me.
#6
Son of a... stupid cnw. This is definitely for review and just needs another review for RTBC.
#7
OK, new contributors need some encouragement so I have reviewed it and like it.
#8
Woohoo! :) Way to go, xmacinfo!
#9
Thanks. Added a paragraph wrapper around the reload link text, and committed.
#10
Automatically closed -- issue fixed for two weeks with no activity.