Undefined index: und in _imagefield_crop_entity_presave()

#1469216: Imagefield Crop does not respect the "help text" witch is set in the config area. is a separate issue.

Can you tell where 0001-Fixing-field-instance-issue.patch comes from?

I cannot separate this problem with particular code that fix it.

No, I'm getting the same error when uploading a photo.

Notice: Undefined index: und in _imagefield_crop_entity_presave() (line 420 of /home/..../public_html/gsrcny/sites/all/modules/imagefield_crop/imagefield_crop.module).
Warning: Invalid argument supplied for foreach() in _imagefield_crop_entity_presave() (line 420 of /home/.../public_html/gsrcny/sites/all/modules/imagefield_crop/imagefield_crop.module).

I'm getting this error when creating a node with crop image field with rules.

re #3, #1358474: Fatal errors: Undefined Index when imagefield_crop field is included in a profile2 entity had committed and included in 7.x-1.1

As you had a working solution, can you download the latest 1.1 and make minimal changes to the code to make it works? So others having the same issue can also test your module.

Sorry for this late reply.

Joe

fraweg: you really need to provide a patch, not a modified copy of the entire module. Patches are far more useful. Just follow the instructions if you're not familiar with making them: http://drupal.org/node/209591/git-instructions/7.x-1.x

In any case, I've encountered the same issue, which was occurring on a node with an empty image field.

Potentially the correct fix is to change this:

    if (!isset($entity->{$field_name})) {
      continue;
    }

into:

    if (empty($entity->{$field_name})) {
      continue;
    }

But as I wasn't 100% certain that it would be sufficient in all circumstances, I've gone with the attached patch.

Thanks! @jweowu

http://drupalcode.org/project/imagefield_crop.git/commit/e5c1c97

You're welcome, and cheers for the quick commit (I believe that link should have been http://drupalcode.org/project/imagefield_crop.git/commit/48fb2fd :)

Ok, imagefield crop on user profile. Please try the patch

Joe

joetsuihk: actually, the patch I supplied in #9 was correct, but a different change was committed :/

If you revert http://drupalcode.org/project/imagefield_crop.git/commit/48fb2fd and apply the patch from #9, that should do the trick.

Re #16, how is it possible to have language translation of a field? Can you list the modules you enabled related to languages?

You get the error when saving a image field attached to user entity?

As per comment #15, the following should resolve this (or at the very least, get things back into a state where people are testing the intended patch).

git reset --hard
git revert --no-commit 48fb2fd0eda309e98b3fc51b020abde064568855
git reset HEAD imagefield_crop.module
git apply imagefield_crop-undefined_index_und-1913412-9.patch

fraweg: If you check out the git repository for the module, as per the instructions here: http://drupal.org/node/209591/git-instructions/7.x-1.x

git clone --branch 7.x-1.x http://git.drupal.org/project/imagefield_crop.git
cd imagefield_crop
git pull origin 7.x-1.x

(which you probably did already to test the existing patches?)

You can then issue the commands I listed to end up with the correctly patched version of the module.

Git is complex, so I don't wish to get into the details (there is plenty of documentation online if you're keen to learn). If you're unsure, just ignore this entirely; I assume joetsuihk will sort it out sometime in the near future.

I do not think we need to revert http://drupalcode.org/project/imagefield_crop.git/commit/48fb2fd?

i mean, apply #9 or #14? #9 and #14? I will test them tomorrow.

joetsuihk: please compare the patch in #9 and the code that was actually committed, and you will see why the problem exists: the additional code from the patch was moved from where it was supposed to be, to an earlier position in the function, which changes the logic entirely.

You can either revert that commit and apply #9, or simply fix the existing code so that it matches. I'm just trying to provide a reliable way forward.

#14 isn't necessary at all. That error only arose because of the mis-positioned code, as the module is now trying to use the lang variable before it's been defined.

Hope this time really fix this issue.

http://drupalcode.org/project/imagefield_crop.git/commit/70162b5

I really don't understand why you've still applied the patch from #14, rather than deleting those lines of code completely? That code just looks wrong, and surely introduces a bug if not all fields use the same language key?

This is why I suggested reverting the original commit and applying the correct patch.

Umm... Looking at the diff that was mentioned in #11 it doesn't appear to be the patch from #9. There's a lot of whitespace edits and the actual code is in the wrong place for it to be from that patch.

joetsuihk, did you add the update by hand or use patch.

The patch as it stands also introduces another bug which the patch at #14 appears to be trying to fix.

I'd go with the suggestion from jweowu in #19. Roll back and apply the initial patch at #9 leaving #14 out for now.

I also noticed that between #9 and #10 the status went from needs review to fixed withough first going through reviewed and tested by the community. This sort of thing would likely not have occured if the usual community based peer-review process was followed. Just saying... ;)

re #26, yes, sorry that I committed some code not yet reviewed. That was a mistake, sorry about that.

About the white space, Drupal coding standard suggest whitespace should be removed, and that is also my config on my sublimetext, that is why whitespace is removed.

A closer look to lines around 417, I suggest remove the few lines altogether, as that check is actually repeated, patch attached.

Good. You'll also want to split that } elseif a few lines below over two lines (again, as per coding standards), but logic-wise this brings us back to #9, so setting the status accordingly.

fraweg: could you please confirm that everything works correctly for you with the patch in #28? (At the moment you're the only other tester.) Thanks!

Exactly right, thanks.

Thanks fraweg. Neither of those are related to this issue, so you should log a new issue for each of them (if none already exist).

joetsuihk, I'd call this RTBC if you'll fix up the formatting issue that I mentioned in #29.

Sorry to kick this issue, but is this ever going to be committed? I have the same error on some sites of mine and would like to get this fixed :).

re #35, please work on #28 patch to follow coding standards as per #34 discussed before we can commit it.

re #35, please work on #28 patch to follow coding standards as per #34 discussed before we can commit it.

I tried to make a new patch with the change proposed in #29, but beware: I have never ever done this (making a patch) and never used Git before, but I wanted to learn it (for everything there is a first time, right?).

So I don't know if I did everything correctly, but I (partly) followed the instructions in https://drupal.org/node/707484. I skipped steps 7, 8 and 9 because I didn't want to commit crap or break something.

I hope I did everything as should and that it can be committed now :).

Thanks @Robert_W, this looks good to me, any other reviewers' comment?

A diff of the current module file with this patch applied, against the old revision with #9 applied (plus subsequent unrelated commits), confirms that they are the same.

Marking RTBC.

Committed, thanks everyone.

http://drupalcode.org/project/imagefield_crop.git/blobdiff/bda65cab912f8...

There is one more check we have to do when processing imagecrop fields - if anything is actually stored in the field, which is sometimes not the case. I made a patch against 7.x-1.1.

I'm using dev version with committed #41 but I'm still getting this error, for some reason field_name is set but it's an empty string.
Using empty() instead of !isset() fixes this problem.

#45 solved this for me. I ran into this issue when trying to migrate a Drupal 6 content type into a Drupal 7 content type using the migrate module. Thanks!

#45 solved to me too.

I applied to 7.x-1.1 version.

Marking RTBC.

Just commited! http://cgit.drupalcode.org/imagefield_crop/commit/?id=f487385

Thanks everyone!

But I think there maybe still another problem mentioned by @lex0r #43. Please reopen if so

I believe #43 is redundant. It looks like an alternative approach to the fix which was already committed (i.e. equivalent to #9).

For reasons I dont understand I got similar errors from this module and I needed an additional condition in this part of the code.