Problem/Motivation

The problem occurs when you're setting up the title & alternative text field requirements on the image field on the article content type. Currently, the alternative text field will dictate if both the title and alternative text fields are required. the title requirement checkbox is currently non functioning.

1. git pull
2. drush si
3. go to manage the image field in an article content type (admin/structure/types/manage/article/fields/field_image)
4. Check: Enable Alt Field, Alt Field Required, Enable Title field. Leave "Title Field Required" unchecked.
5. Save Settings
6. Goto node/add/article
7. Enter value into title.
8. In Image Field, Choose File and click Upload. Alternative Text & Title fields appear.
9. Enter value into Alternative Text field, leave Title field blank.
10. Click Save & Publish.

Error: The field Title is required.

Proposed resolution

See patch. The title requirement field was correctly being created, this appears to be just be an issue with correctly targeting the validation.

CommentFileSizeAuthor
#4 issue-1913712-image-field-setup.png100.8 KBvegantriathlete
#4 1913712-image-title-field-required-reproduced.png111.85 KBvegantriathlete
#4 issue-1913712-after-patch-applied.png130.1 KBvegantriathlete
#4 optional_title_reroll-1913712-4.patch708 bytesvegantriathlete
#3 image-settings.png347.98 KBpameeela
#3 empty-title.png198.41 KBpameeela
#1 image_title_validation-1913712-1.patch682 byteschrismiller627
Screen shot 2013-02-10 at 3.10.40 PM.png80.41 KBchrismiller627
Screen shot 2013-02-10 at 3.04.56 PM.png32.34 KBchrismiller627
Screen shot 2013-02-10 at 3.04.45 PM.png33.59 KBchrismiller627
Screen shot 2013-02-10 at 3.04.05 PM.png26.83 KBchrismiller627

Comments

chrismiller627’s picture

chrismiller627 commented
StatusFileSize
new image_title_validation-1913712-1.patch682 bytes

This patch should take care of the issue.

chrismiller627’s picture

chrismiller627 commented
Status: Active » Needs review
Issue tags: +Needs manual testing
pameeela’s picture

pameeela commented
StatusFileSize
new empty-title.png198.41 KB
new image-settings.png347.98 KB

I've tested this patch manually and it works. Screenshots attached.

Steps:

  1. Apply patch
  2. go to manage the image field in an article content type (admin/structure/types/manage/article/fields/field_image)
  3. Check: Enable Alt Field, Alt Field Required, Enable Title field. Leave "Title Field Required" unchecked.
  4. Save Settings
  5. Goto node/add/article
  6. Enter value into title.
  7. In Image Field, Choose File and click Upload. Alternative Text & Title fields appear.
  8. Enter value into Alternative Text field, leave Title field blank.
  9. Click Save & Publish.
  10. Node saves successfully

image-settings.png

empty-title.png

vegantriathlete’s picture

vegantriathlete
he/him/his
Primary language English
Location Lakewood, CO
commented
StatusFileSize
new optional_title_reroll-1913712-4.patch708 bytes
new issue-1913712-after-patch-applied.png130.1 KB
new 1913712-image-title-field-required-reproduced.png111.85 KB
new issue-1913712-image-field-setup.png100.8 KB

The code has changed. I have rolled a new patch and tested it.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Needs review » Closed (duplicate)

I can confirm this bug. I also discovered this while working at #2072995: Move FAPI callbacks for file/image widgets in classes. I fixed the error there (see patch from #2072995-7: Move FAPI callbacks for file/image widgets in classes). Let's keep that one because it's part of D8 conversion.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Issue summary: View changes

Update the solution a bit.