Missing font preview potentially confusing [#1913976]

This is follow-up to #1134676: Only show fonts on the default theme.

Turning 'load fonts in all themes' off breaks font preview if admin theme != default theme; this is so in a standard install, and some users may even not realize they're using a different admin theme. Although 'load fonts in all themes' is on by default, there's still a potential for confusion. (doh, I even managed to get myself confused).

Proposed solution: add a warning if there are good reasons to believe the user is looking at a broken font preview.

Patch coming.

Comment	File	Size	Author
#1	fontyourface-Missing_font_preview_potentially_confusing-1913976-1.patch	1.7 KB	Drave Robber

Comments

Comment #1

Drave Robber commented 11 February 2013 at 09:39

Status:

Active

» Needs review

Status	File	Size
new	fontyourface-Missing_font_preview_potentially_confusing-1913976-1.patch	1.7 KB

Patch attached.

Comment #2

BarisW commented 11 February 2013 at 09:43

Another option would be to add a check in hook_preprocess_html() to see if we're on the admin page (admin/appearance/fontyourface/*) and if so; don't return.

Comment #3

Drave Robber commented 11 February 2013 at 10:12

Then you could get sudden change in look as you go from admin/appearance to admin/appearance/fontyourface, if there are fonts with general selectors like <h2> or <p>.