I have added support for custom variables to "dataLayer".

Also it support multiple variables, and tokens. :)

CommentFileSizeAuthor
#6 google_tag_manager_1914210-6.patch3.9 KBnaxoc
#5 google_tag_manager_support_custom_variables-5.patch3.74 KBxen
#4 google_tag_manager_support_custom_variables-4.patch3.67 KBxen
#1 google_tag_manager_support_custom_variables.patch5.47 KBElvar

Comments

Elvar’s picture

Elvar commented
StatusFileSize
new google_tag_manager_support_custom_variables.patch5.47 KB

And with the attach button pressed this time.

lsolesen’s picture

lsolesen commented
Status: Active » Needs review
sgerrand’s picture

sgerrand commented
Status: Needs review » Needs work

Thanks for taking the time to create this patch. Apologies for taking so long to reply.

The changes look OK. Can you please add tests for the new behaviour that has been introduced.

xen’s picture

xen commented
StatusFileSize
new google_tag_manager_support_custom_variables-4.patch3.67 KB

Rerolled against 91bcfdb.

xen’s picture

xen commented
StatusFileSize
new google_tag_manager_support_custom_variables-5.patch3.74 KB

Previous patch kinda went south.

New reroll.

naxoc’s picture

naxoc commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new google_tag_manager_1914210-6.patch3.9 KB

Patch updates handling of the "dataLayer" variable to be more robust.