Download & Extend
Link » Issues

'title_value' in 'link_field_update_instance' undefined

Posted by thudfactor on February 11, 2013 at 4:18pm
Project:Link
Version:7.x-1.x-dev
Component:Code
Category:bug report
Priority:major
Assigned:Unassigned
Status:reviewed & tested by the community

Issue Summary

Noticed this after upgrading to 7.x-1.1 today -- happens when saving from the "Manage Display" tab on Content Types:

Notice: Undefined index: title_value in link_field_update_instance() (line 1305 of /var/www/foo/public/sites/all/modules/link/link.module)

This appears to fire once for each field regardless of whether or not it's a link. This is happening to me for content types that do not have link fields in them. The implementation of link_field_update_instance does not appear to do any testing to see if the field being modified is a link field.

This sounds similar to the bug at http://drupal.org/node/949604, but the error is happening in new code.

Login or register to post comments

Comments

#1

Posted by v.zhakov on February 11, 2013 at 5:17pm

Hello!

I have the same issue.

After I have added this field, it shows twice:

    Notice: Undefined index: title_value ... link_field_update_instance()
    Notice: Undefined index: title_value ... link_field_update_instance()

(line 1305 in sites/all/modules/link/link.module)

I have Drupal 7.19.

#2

Posted by facine on February 11, 2013 at 11:53pm
Status:active» needs review

Hello, attached patch.

AttachmentSize
Fixed_title_value_in_link_field_update_instance_undefined-1914286-3.patch 783 bytes

#3

Posted by jcfiala on February 12, 2013 at 12:02am

A patch! Bless you. Can someone take a look at this?

#4

Posted by luisortizramos on February 12, 2013 at 12:14pm
Status:needs review» reviewed & tested by the community

I've tested the patch and it seems to work.

#5

Posted by plord on February 13, 2013 at 10:37am

Thanks patch worked to me. Seemed to have occurred when I upgraded from Debian Squeeze to Debian Wheezy which is php 5.4.4-12

#6

Posted by Gyver on February 13, 2013 at 10:55am

Patch works for me too, thank you very much.

#7

Posted by jneubert on February 13, 2013 at 12:23pm

Thanks, works for me, too

#8

Posted by weri on February 13, 2013 at 3:44pm

The patch is working for me.

#9

Posted by jcfiala on February 13, 2013 at 4:13pm

Thanks folks, I'll try to get this into the dev branch as soon as possible, and do some more testing with i18n over the weekend to try and nail down any other problems that the latest version introduced.

#10

Posted by czigor on February 13, 2013 at 8:35pm

#2 works for me too.

#11

Posted by 7wonders on February 13, 2013 at 9:10pm

yep, works here too

#12

Posted by mattlc on February 14, 2013 at 9:22pm

Seams to work too for me. Thanks !

#13

Posted by Ted51 on February 17, 2013 at 12:30pm

The notice still appears after the first "Save content type" when I create a new content type. For the others cases the patch works for me too. Thanks

#14

Posted by ilrecidivo on February 19, 2013 at 1:50pm

#2 Thanks!

#15

Posted by opi on February 20, 2013 at 9:18am

#2 works great. Can't wait for this patch to be applied.

#16

Posted by doitDave on February 20, 2013 at 2:05pm

Subscribing, please apply and roll out asap. Hopefully one day PHP will not allow uninitialized variables at all, because this is where that lazy typing stuff lead us to 8-(

#17

Posted by navalogan on February 20, 2013 at 3:25pm

it's work for me too! thanks!

#18

Posted by webadpro on February 20, 2013 at 7:32pm

Please commit this patch.

#19

Posted by jhodgdon on February 20, 2013 at 9:07pm

I applied this patch on a site with i18n, and it works fine to remove the PHP notices, so another +1 for committing it from me.

#20

Posted by g0blin79 on February 21, 2013 at 3:09pm

Yes it works for me too! Include it in a new module version pleaze! :)

#21

Posted by ShaneOnABike on February 22, 2013 at 2:35am
Priority:normal» major

Works for me too can we not deploy this!

#22

Posted by jawad.shah on February 22, 2013 at 7:32am

ref #2
Yes, patch works perfect.
Thanks facine.

zeropoint.IT

#23

Posted by s1l on February 22, 2013 at 2:39pm

Commerce Kickstart uses Link 7.x-1.1
Got this notice when upgrading to Commerce Kickstart 2.4 right after running update.php (Drupal core 7.20)

#24

Posted by ibarrajo on February 22, 2013 at 5:40pm

excellent #2!

#25

Posted by alexweber on February 23, 2013 at 6:56pm

I can haz commit?

Confirm that it works on a website (with i18n).

Thanks!

#26

Posted by imagenews on February 24, 2013 at 5:18am

not sure how to apply this patch, I'll need to load via cpanel because I don't know any other way, what file and where do I add this patch to? Thanks in advance.

#27

Posted by herbiek on February 24, 2013 at 10:45am

Not sure which permissions you have, depending on the method you want to use (manually or via command line interface) you can try following this description: http://drupal.org/patch/apply

#28

Posted by alexweber on February 24, 2013 at 4:00pm

@imagenews If you're using unix just follow these simple steps:

  1. cd into the module's directory
  2. wget http://drupal.org/files/Fixed_title_value_in_link_field_update_instance_undefined-1914286-3.patch
  3. patch -p1 < Fixed_title_value_in_link_field_update_instance_undefined-1914286-3.patch
  4. Profit!

#29

Posted by maxplus on February 26, 2013 at 10:36am

Thanks!

#2 worked for me with current Drupal Commerce Kickstart 7.x-2.4 and Link 7.x-1.1

#30

Posted by grkm2002 on February 26, 2013 at 3:51pm

downloaded patch to link folder and ran the patch command. However I get "patch: **** strip count 1 is not a number"

Any help would be great. Hate having all those notices

#31

Posted by alexweber on February 26, 2013 at 5:35pm

if the patch doesn't apply you're probably not using the latest stable release of the module.

#32

Posted by jhodgdon on February 26, 2013 at 6:40pm

RE #30 - you may have also used a lower-case L instead of a number 1 when you typed in the patch command in #28. It should be "patch minus lower-case-p number-one" in step 3 of #28. That is what the error looks like to me.

#33

Posted by grkm2002 on February 26, 2013 at 6:51pm

Thanks. It works. Was using a lower "L" instead of a the number 1.

#34

Posted by kurtzhong on February 28, 2013 at 7:09am

It works well, thanks.

#35

Posted by leanderl on March 1, 2013 at 1:20pm

Thanks for the patch in #2! Works like a charm.

#36

Posted by hedmon on March 1, 2013 at 3:49pm

@facine perfecto! gracias una vez más!

#37

Posted by dimitriseng on March 2, 2013 at 1:17am

I can confirm #2 resolves the issue, please commit, thank you.

#38

Posted by flying dutchman on March 2, 2013 at 1:42pm

#2 worked like a charm! Thanks @facine!

#39

Posted by oana.hulpoi on March 3, 2013 at 6:33am

Thanks, @facine!

#40

Posted by Daniel Wentsch on March 11, 2013 at 10:46am

Confirming #2 working with i18n and domain_access. Thanks!

#41

Posted by cara1940 on March 13, 2013 at 9:15am

After applying patch #2 I get the following error message

Notice: Undefined index: in theme_field_ui_table() (line 256 of ../modules/field_ui/field_ui.admin.inc).
Warning: Invalid argument supplied for foreach() in element_children() (line 6370 of ../includes/common.inc).

#42

Posted by Neli on March 14, 2013 at 4:02pm

#2 worked, thanks facine.

#43

Posted by gianfrasoft on March 15, 2013 at 8:24am

#2 worked for me too, thanks.

#44

Posted by vacho on March 18, 2013 at 8:17pm

works!!

#45

Posted by wangqizhong on March 27, 2013 at 1:01pm

Thanks for the patch, @facine

#46

Posted by kingfisher64 on March 27, 2013 at 7:58pm

Lovely, can this be committed asap?

#47

Posted by eTech on March 29, 2013 at 12:43pm

Applied the patch manually and it works, thnx!

#48

Posted by hswong3i on March 30, 2013 at 1:27am

#2 also works for me, which I had already apply it to DruStack as reference from Commerce Kickstart.

#49

Posted by hswong3i on March 30, 2013 at 1:27am
Version:7.x-1.1» 7.x-1.x-dev

#50

Posted by jasom on April 4, 2013 at 8:35am

With #2 error disappear.

#51

Posted by jaimecarrion on April 6, 2013 at 2:59pm

Patch worked like a charm. Thanks Alex!

#52

Posted by stred on April 9, 2013 at 2:42pm

worked for me too!

#53

Posted by jasom on April 10, 2013 at 2:12pm

#42 #43 #44 #47 #50 #51 #52 :)

You don't say?

AttachmentSize
youdontsay.png 89.8 KB

#54

Posted by stevepurkiss on April 18, 2013 at 12:13pm

works for me too ;)

#55

Posted by fayedrupal on April 19, 2013 at 7:08pm

Thank you #2 facine, it worked

#56

Posted by MXT on April 20, 2013 at 10:42pm

Patch provided on #2 works very well.

Can this be committed please?

#57

Posted by johantar on April 22, 2013 at 8:11am

Patch provided on #2 worked for me. Thank you!

#58

Posted by razkovnik on April 23, 2013 at 8:11am

Patch works for me too! Cheers!

#59

Posted by a.ross on April 23, 2013 at 9:04am

+++ b/link.module
@@ -1302,7 +1302,7 @@ function link_field_item_property_info() {
+  if (function_exists('i18n_string_update') && $instance['widget']['type'] == 'link_field' && $prior_instance['settings']['title_value'] != $instance['settings']['title_value']) {

I would prefer to test for widget type first and only then check the other conditions. But can this please be committed?

#60

Posted by SeyVaneerdewegh on April 24, 2013 at 1:32pm

Patch in #2 fixes the annoying error. Please can this be commited?

#61

Posted by RaulMuroc on April 26, 2013 at 4:27pm

Come on!! Somebody commit it!

#62

Posted by GiorgosK on April 30, 2013 at 4:29am

#9 asks for i18n tests
#19, #25, #40 confirm it to be working on an i18n enabled site
I am also confirming i18n enabled site its working like a charm

please commit at least on the DEV version

#63

Posted by Bison on May 2, 2013 at 5:17pm

It works Indeed

#64

Posted by aantonop on May 5, 2013 at 8:23pm

Works on i18n with multiple enabled languages.

#65

Posted by webadpro on May 8, 2013 at 3:15pm

I think this patch as been tested more than enough times and the dev should be committing this patch.

#66

Posted by twooten on May 11, 2013 at 6:26am

#53 That's freakin hilarious!

#67

Posted by kobee on May 14, 2013 at 2:19pm

+1 for committing the patch.

nobody click here