Problem/Motivation

dropbutton cuts off long action item, either in the button or at the edge of the window.

Actual text in 8.x core: "no translatable fields"

long-2013-02-11_2340.png

simulated long text in another area:

long-2013-02-11_0649.png

Also, other languages might translate words to longer text that the English. (would be good to show an example)

Proposed resolution

TBD.

Remaining tasks

  • propose solutions, maybe make the width of the button the longest item?
  • pick on solution to implement the patch for

User interface changes

No new pattern, just fixing dropbuttons with long text in them.

API changes

No API changes expected.

Originally...

Related
#1849750-12: Minimize all "Operations" columns width
#1188388-184: Entity translation UI in core 2.
#1890266: dropbutton text fails to retain .dropbutton-widget width

CommentFileSizeAuthor
long-2013-02-11_0649.png58.97 KByesct
long-2013-02-11_2340.png68.24 KByesct

Comments

yesct’s picture

yesct commented
Issue tags: +D8MI

tagging d8mi since one of the entity translation strings is involved, but it's also a general issue that would effect other areas/strings.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: set width of dropbutton to width of longest item » Dropbutton width is smaller than longest item
Priority: Minor » Normal

Closely related: #1899236: Add new Splitbutton render element to eventually replace Dropbutton

yesct’s picture

yesct commented
Title: Dropbutton width is smaller than longest item » set width of dropbutton to width of longest item
Priority: Normal » Minor

steps to reproduce (the no translatable fields case):

  • install
  • enable content translation under extend
  • add a couple languages
  • enable translation on the article content type, from admin/structure/types/manage/article, not from the cool content settings screen (do not enable translation on article fields)
  • create an article
  • go to the translations tab on that article

steps to reproduce (a general case, faked):

  • create any content
  • go to content listing
  • use firefox firebug or chrome devel tools or something like that to edit the html of an item in the dropbutton to make it long.

I'm not sure if this second case really is a test case. in this second case, the dropbutton grows, but exceeds the column and then runs into the width of the window. in the first case above, the words inside the dropbutton are cut off at the width of it.

yesct’s picture

yesct commented
Title: set width of dropbutton to width of longest item » Dropbutton width is smaller than longest item
Priority: Minor » Normal

cross post

edrupal’s picture

edrupal commented
Status: Active » Needs review

This seems similar to #1890266: dropbutton text fails to retain .dropbutton-widget width.

I tested the latest patch in that issue and it seemed to resolve the problem here as well. The patch hasn't been reviewed yet so can't say if it's a valid approach.

yesct’s picture

yesct commented
Issue tags: +Novice
oresh’s picture

oresh commented
Status: Needs review » Closed (duplicate)

@edrupal is right, #1890266: dropbutton text fails to retain .dropbutton-widget width. covers this bug, it was created before this and has more work/discussion.
Marked as duplicated.

oresh’s picture

oresh commented
Issue summary: View changes

Update too related issues section