Inserting link not working in IE9 and below when making text selection (with ckeditor 4) [#1915086]

Comment	File	Size	Author
#17	1915086-17.patch	1.46 KB	anon
#1	ie9-loses-text-selection-modal-focus.jpg	135.46 KB	filsterjisah

Comment #0.0

filsterjisah CreditAttribution: filsterjisah commented 12 February 2013 at 13:15

Issue summary:

View changes

copy

Log in or register to post comments

Comment #0.1

filsterjisah CreditAttribution: filsterjisah commented 14 February 2013 at 13:49

Issue summary:

View changes

copy

Log in or register to post comments

Comment #1

filsterjisah CreditAttribution: filsterjisah commented 18 February 2013 at 07:28

File	Size
ie9-loses-text-selection-modal-focus.jpg	135.46 KB

At the moment the focus in the dialog window is trigger, the text selection gets lost (IE 10 & below). Could be a limitation in IE?

I think this can be fixed by storing the text selection in a temporary variable (somewhere before putting the focus on the search input field). When submitting / cancelling the dialog window we could reselect the stored text. Any ideas?

The default link plugin seems to work fine, I'll have a look into that.

Log in or register to post comments

Comment #2

anon

Swedish

Gothenburg

CreditAttribution: anon commented 18 February 2013 at 15:02

Linkit is saving the selection in a temporary variable for just this reason.

Log in or register to post comments

Comment #3

filsterjisah CreditAttribution: filsterjisah commented 21 February 2013 at 09:05

I just did a fresh drupal install with ckeditor 4:
- when creating a new link by selection of some parts of the text in the editor, I'm still experiencing this error.
- When editing a link, everything works just fine.

@anon, have you tried this in IE?

Log in or register to post comments

Comment #4

anon

Swedish

Gothenburg

CreditAttribution: anon commented 22 February 2013 at 08:25

Yes I have. Tho It seems like I will have to test it again.

Log in or register to post comments

Comment #5

Anonymous (not verified) CreditAttribution: Anonymous commented 22 February 2013 at 09:17

I'm experiencing the same issue with IE 8/9.

- select text
- press linkit icon; popup opens
- previously selected text is now unselected, visible in the background

Log in or register to post comments

Comment #6

Anonymous (not verified) CreditAttribution: Anonymous commented 28 February 2013 at 11:32

Is there a way I can help with this issue? This seems to me like a "major" bug as it prevents everyone using CKeditor with IE from using the module (which, I guess, affects a lot of "end users"). I tried to debug the JS but I couldn't find any hint as to where the problem could be. My experience with CKeditor's architecture is close to zero, tho. :-( I will have a look at it again, meanwhile I'd be happy to test any patches provided.

Log in or register to post comments

Comment #7

anon

Swedish

Gothenburg

CreditAttribution: anon commented 5 March 2013 at 23:31

This does work in IE9 on win7!

The link isn't hightlighted after that you have pressed "Insert link" tho, but the link is inserted.

Log in or register to post comments

Comment #8

anon

Swedish

Gothenburg

CreditAttribution: anon commented 5 March 2013 at 23:33

At the moment the focus in the dialog window is trigger, the text selection gets lost (IE 10 & below). Could be a limitation in IE?

Yes, that is a limitation in IE.

Log in or register to post comments

Comment #9

Anonymous (not verified) CreditAttribution: Anonymous commented 5 March 2013 at 23:38

Did you test with ckeditor version 3 or 4?

Log in or register to post comments

Comment #10

anon

Swedish

Gothenburg

CreditAttribution: anon commented 6 March 2013 at 12:19

Ckeditor lib 3. (with wysiwyg)

Linkit lacks support for Ckeditor lib 4.

Log in or register to post comments

Comment #11

Anonymous (not verified) CreditAttribution: Anonymous commented 6 March 2013 at 12:24

Ah, that explains. Funny thing is: CKeditor 4 + LinkIt works well in every other browser than IE, even if it is "unsupported". That's why I thought that this must be a bug. I didn't know that version 4 of ckeditor is unsupported. Maybe you should clarify that on the module page.

Log in or register to post comments

Comment #12

filsterjisah CreditAttribution: filsterjisah commented 6 March 2013 at 14:43

I'm using CKEditor 4 too.
+1 for mentioning on the module page

Log in or register to post comments

Comment #13

anon

Swedish

Gothenburg

CreditAttribution: anon commented 6 March 2013 at 16:00

Are you using a patched version of wysiwyg?

Log in or register to post comments

Comment #14

Anonymous (not verified) CreditAttribution: Anonymous commented 6 March 2013 at 16:22

Im using http://drupal.org/project/ckeditor (latest stable).

Log in or register to post comments

Comment #15

filsterjisah CreditAttribution: filsterjisah commented 7 March 2013 at 06:59

Me too, CKEditor 7.x-1.12

Log in or register to post comments

Comment #16

anon

Swedish

Gothenburg

CreditAttribution: anon commented 7 March 2013 at 21:49

Title:

Not working in IE9 and below when making text selection

» Insertinbg link not working in IE9 and below when making text selection (with ckeditor 4)

Issue confirmed..

I will see what I can do.

Log in or register to post comments

Comment #17

anon

Swedish

Gothenburg

CreditAttribution: anon commented 21 March 2013 at 08:34

Status:

Closed (fixed)

» Needs review

File	Size
1915086-17.patch	1.46 KB

Try this patch..

EDIT: THIS PATCH IS FOR 7.x-3.x

Log in or register to post comments

Comment #18

Anonymous (not verified) CreditAttribution: Anonymous commented 8 March 2013 at 10:25

Title:	Insertinbg link not working in IE9 and below when making text selection (with ckeditor 4)	» Inserting link not working in IE9 and below when making text selection (with ckeditor 4)
Status:	Active	» Needs review

Applied cleanly to 2.x-dev, links get inserted correctly in IE8/XP.

Thanks!

Log in or register to post comments

Comment #19

anon

Swedish

Gothenburg

CreditAttribution: anon commented 8 March 2013 at 11:14

Status:

Needs review

» Fixed

Patch in #17 commited.

Log in or register to post comments

Comment #20

filsterjisah CreditAttribution: filsterjisah commented 8 March 2013 at 14:26

I've tested in ff, chrome, safari & ie (8-10) and all works fine.
Thanks!

Log in or register to post comments

Comment #21

filsterjisah CreditAttribution: filsterjisah commented 20 March 2013 at 14:28

Status:

Fixed

» Needs work

I think we missed something: you should try the other way now, adding a link without selecting text. This doesn't work anymore.

When pressing the insert button, you'll get redirect to /linkit/dashboard/ckeditor because of the "Drupal.settings.linkit.currentInstance.linkContent is undefined"-error.

Replacing line 18 of the patch:
var content = (Drupal.settings.linkit.currentInstance.linkContent) ? Drupal.settings.linkit.currentInstance.linkContent : data.path;
by
var content = (Drupal.linkitCache.link_tmp_title) ? Drupal.linkitCache.link_tmp_title : data.path;
fixed the problem for me.

Log in or register to post comments

Comment #22

anon

Swedish

Gothenburg

CreditAttribution: anon commented 20 March 2013 at 18:39

What version are you using??

There is no "Drupal.settings.linkit.currentInstance.linkContent" in 7.x-2.x as I can see.

If you using 7.x-3.x "Drupal.linkitCache.link_tmp_title" doenst exists.

Log in or register to post comments

Comment #23

filsterjisah CreditAttribution: filsterjisah commented 21 March 2013 at 07:21

I'm using 7.x-2.5.

Indeed, couldn't find Drupal.settings.linkit.currentInstance.linkContent either.
That's why I replaced it back with the original js variable (Drupal.linkitCache.link_tmp_title).

Log in or register to post comments

Comment #24

anon

Swedish

Gothenburg

CreditAttribution: anon commented 21 March 2013 at 08:30

Status:

Needs work

» Closed (fixed)

Say what??!?

"Drupal.settings.linkit.currentInstance.linkContent" doesn't exists at all in the code for 7.x-2.x!

How can you then change it??? You must have done something wrong.

Drupal.settings.linkit.currentInstance.linkContent is a new thing for Linkit 7.x-3.x.

Please make sure you have the latest version of Linkit (7.x-2.6 or 7.x-2.x).

Log in or register to post comments

Comment #25

anon

Swedish

Gothenburg

CreditAttribution: anon commented 21 March 2013 at 08:32

Also, the patch in #17 does NOT apply to 7.x-2.x, its for 7.x-3.x

Log in or register to post comments

Comment #26

filsterjisah CreditAttribution: filsterjisah commented 21 March 2013 at 11:38

Version:	7.x-2.x-dev	» 7.x-3.x-dev
Status:	Needs review	» Closed (fixed)

I think there's a misunderstanding here between version 2 & 3. The issue I reported was for version 2. Since the patch was written for version 3, there was still something wrong with it when I applied it to my project (version 7.x-2.5). I did change the code in your patch, not in the linkit original code.

7.x-2.6 looks the same as applying the patch to 7.x-2.5, so an upgrade would fix the problem too :)

Thanks a lot for your great module.