remove the length settings, or make that hidden somewhere.That's a kind of setting I forgot: the "please don't fail" option.

These are not just a "please don't fail" option. They allow you to limit to so it fits without wrapping in email, for example, or have it long because you don't care about email. There are several issues in the queue with multiple followups showing that they are used and important. I do plan to move them to a "variable only" location since they seem like they area low value.

You could also avoid the transliteration options, and always transliterate if you find the i18n-ascii.txt file.

Great point.

All the help stuff should be shown on mouseover or with a click.

The token pattern suggestions should be in collapsible fieldsets like the rest of the token modules do it. Any other of the "all the help stuff" I don't plan to hide via special code in pathauto. That should be a core function.

CommentFileSizeAuthor
#6 191509-transliteration-D6-2.patch2.08 KBdave reid

Comments

webchick’s picture

I don't know if this is related to the comments above, but it is UI related. Addi showed me the Punctuation settings fieldset on the settings page. DEAR LORD.

It seems to me this could be three text boxes:

- Remove these characters
- Replace these characters
- Leave these characters alone

And then the textfield gets a string like:

!@#$%^&*()_

Which they can edit/add to as desired.

greggles’s picture

@webchick - interesting idea. I spent some time working on that via the "strings to remove" textbox but couldn't find the regex magic that would get it done. If you can, great.

My current plan for those is to remove them all and default them to "replace with separator" and then use hidden variables that people can set to control them. So, even less UI pain.

Freso’s picture

Version: 5.x-2.x-dev » 7.x-1.x-dev

@webchick, greggles: I'm definitely with you, Greg, for moving them to hidden variables. Unless I get to determine Pathauto's default actions, I would rather use my own settings for these. I'm perfectly comfortable with doing this in e.g. settings.php (I'm already defining a bunch of my static variables there anyway), and I think most users who care about this, would be able to figure it out as well. Also, we only really need to take care of these few characters from the ASCII set, that aren't "URL safe". If they're Unicode characters, they should be dealt with by way of transliteration (IMHO).

I think the Transliteration option should stay. It's a single checkbox, and people might or might not want to utilise it. Especially considering it now being dependent of another module which might not have been brought in because of Pathauto (as opposed to checking for an i18n-ascii.txt file, which could be presumed with a good probability to have been put there by the webmaster/admin to take care of transliteration).

I'm undecided on the length settings. After your description, I'd probably want to lower my own "barrier" so that it'll be more manageable in e-mails etc., but OTOH, 50-80 characters might be too few for a lot of folks who don't care about e-mails, while 100 characters is obviously too much for those that do... Perhaps we should instead make this some sort of dropdown? "Short (20,30?) | Suitable for e-mail (50,60,70?) | Long (100) | Maximum (110,120?)" *shrugs*

Freso’s picture

I created a separate issue/task for removing the "Punctuation settings" from the UI: #296098: Remove "Punctuation settings" from UI

greggles’s picture

Title: UI review from devel list » If transliteration module is not installed, hide the transliteration checkbox
Assigned: greggles » Unassigned

So, given that punctuation settings was split out and other things are by design, I think the last thing to do here is disable the transliteration checkbox if transliteration module is disabled.

Freso and I discussed this...his concern is that if we remove the checkbox people won't know about that feature. However, that is documented in INSTALL.txt and on the Pathauto project page...so my vote is to do this one piece out of the list of ideas.

dave reid’s picture

Status: Active » Needs review
StatusFileSize
new2.08 KB

Patch attached for review that hides the transliteration checkbox if the module does not exist.

dave reid’s picture

Status: Needs review » Fixed

This is already fixed now with some previous form cleanups.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.