I have a Canadian phone number field with the "Add the country code if not filled by the user" option selected. When a number without a country code is entered, the country code is prefixed to the field. But when a country code is provided, the country code is removed.

In format_ca_phone_number, a valid entered country code is never added to $phonenumber.

CommentFileSizeAuthor
#3 keep_provided_ca_country_code-1915188-3.patch939 bytespbuyle
#2 keep_provided_ca_country_code-1915188-2.patch937 bytespbuyle
#1 keep_provided_ca_country_code-1915188-1.patch907 bytespbuyle

Comments

pbuyle’s picture

pbuyle commented
StatusFileSize
new keep_provided_ca_country_code-1915188-1.patch907 bytes

The attached patch preprend the country code extracted from the input. The country code is validated and will have to be 1 if provided. If the "_Add the country code if not filled by the user_", the country code is prepended only if not already provided.

pbuyle’s picture

pbuyle commented
StatusFileSize
new keep_provided_ca_country_code-1915188-2.patch937 bytes

A space is needed after the country code.

pbuyle’s picture

pbuyle commented
StatusFileSize
new keep_provided_ca_country_code-1915188-3.patch939 bytes

I should test my patch before hitting submit...

pbuyle’s picture

pbuyle commented
Issue summary: View changes
Status: Active » Needs review
drclaw’s picture

drclaw commented

I can confirm that the patch performs as advertised. Thanks! :)