Move _breakpoint_delete_breakpoints() into BreakpointGroupStorageController

This is still crazypants.

1. +++ b/core/modules/breakpoint/breakpoint.module
   @@ -6,6 +6,7 @@
    use Drupal\breakpoint\Entity\Breakpoint;
   +use Drupal\breakpoint\BreakpointGroupStorageControllerInterface;
    use Drupal\breakpoint\Entity\BreakpointGroup;
    use Drupal\Core\Config\Entity\ConfigStorageController;
   

   I'm guessing some of these use statements can be removed now.

2. +++ b/core/modules/breakpoint/breakpoint.module
   @@ -49,7 +50,7 @@ function breakpoint_help($path, $arg) {
   +  \Drupal::entityManager()->getStorageController('breakpoint_group')->_breakpoint_delete_breakpoints($theme_list, Breakpoint::SOURCE_TYPE_THEME);
   
   +++ b/core/modules/breakpoint/lib/Drupal/breakpoint/Controller/BreakpointGroupStorageController.php
   @@ -0,0 +1,76 @@
   +  function _breakpoint_delete_breakpoints(array $list, $source_type) {
   
   +++ b/core/modules/breakpoint/lib/Drupal/breakpoint/Controller/BreakpointGroupStorageControllerInterface.php
   @@ -0,0 +1,26 @@
   +  public function _breakpoint_delete_breakpoints(array $list, $source_type);
   

   This should be renamed to something like deleteBreakpointsBySource or something?

3. +++ b/core/modules/breakpoint/lib/Drupal/breakpoint/Controller/BreakpointGroupStorageController.php
   @@ -0,0 +1,76 @@
   +    $ids = \Drupal::configFactory()->listAll('breakpoint.breakpoint_group.' . $source_type . '.');
   +    $entity_manager = \Drupal::entityManager();
   ...
   +        $breakpoint_ids = \Drupal::service('config.storage')->listAll('breakpoint.breakpoint.' . $source_type . '.' . $breakpoint_group->id() . '.');
   

   We should implement EntityControllerInterface and use that for injecting these services.

4. +++ b/core/modules/breakpoint/lib/Drupal/breakpoint/Controller/BreakpointGroupStorageController.php
   @@ -0,0 +1,76 @@
   +   * Remove breakpoint groups from all disabled themes or uninstalled modules.
   
   +++ b/core/modules/breakpoint/lib/Drupal/breakpoint/Controller/BreakpointGroupStorageControllerInterface.php
   @@ -0,0 +1,26 @@
   +   * Remove breakpoints from all disabled themes or uninstalled modules.
   

   "Removes"

5. +++ b/core/modules/breakpoint/lib/Drupal/breakpoint/Controller/BreakpointGroupStorageController.php
   @@ -0,0 +1,76 @@
   +    $breakpoint_groups = $this->loadMultiple();
   +    foreach ($breakpoint_groups as $breakpoint_group) {
   +      if ($breakpoint_group->sourceType == $source_type && $breakpoint_group->source == $group_id) {
   +        $breakpoint_group->delete();
   +      }
   +    }
   

   There is a possibility we can rewrite this to use loadByProperties, but that should wait for the patch to pass first.

6. +++ b/core/modules/breakpoint/lib/Drupal/breakpoint/Entity/BreakpointGroup.php
   @@ -18,6 +18,9 @@
   + *   controllers = {
   + *     "storage" = "Drupal\breakpoint\BreakpointGroupStorageController",
   + *   }
     *   entity_keys = {
     *     "id" = "id",
   

   You're missing a comma after the } the line before entity_keys, which is why this failed to install.

Ahh, this will always cause problems:
You had Drupal\breakpoint\BreakpointGroupStorageController but core/modules/breakpoint/lib/Drupal/breakpoint/Controller/BreakpointGroupStorageController.php

Extra "Controller" in there.

I also fixed up the DI, we need the breakpoint entity type and storage controller.

13: breakpoint-1915272-13.patch queued for re-testing.

Hmmm, #2080823: Create API to discover config entities' soft dependencies and use this to present a confirm form on module uninstall completely removes every line from this patch. Maybe this is just a dupe of that one?