Currently the message_subscribe_email feature is under the general 'features' tab by default. It should be moved into the Messages project.

CommentFileSizeAuthor
#2 1915364-message-subcsribe-remove-features-info-2.patch770 bytesezra-g
message_subscribe_email_package.patch501 bytesjaperry

Comments

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Needs review » Needs work

Actually message_subscribe_email should not be a "feature". I prefer to manually declare all the needed hooks. Any chance you can work on it?

ezra-g’s picture

ezra-g commented
Status: Needs work » Needs review
StatusFileSize
new 1915364-message-subcsribe-remove-features-info-2.patch770 bytes

Message subscribe already implements the necessary hooks. The only thing we need to do to prevent it from being a Features module is to remove the Features-specific entries from the .info file.

ezra-g’s picture

ezra-g commented
Title: Message Subscribe email should exist within other message features » Remove unnecessary Features lines from message_subscribe_info file
achton’s picture

achton
Location Denmark
commented

Sorry, can't get #3 to apply against current -dev version.

patching file message_subscribe_email/message_subscribe_email.info
Hunk #2 FAILED at 7.
1 out of 2 hunks FAILED -- saving rejects to file message_subscribe_email/message_subscribe_email.info.rej
ezra-g’s picture

ezra-g commented

It will only apply to the module pulled from Git - the dev version is packaged with added lines in the .info that cause the patch to fail.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.