Download & Extend
Issues

Split up Profile module

Posted by Rob Loach on November 12, 2007 at 4:51pm
Project:Drupal core
Version:6.x-dev
Component:profile.module
Category:task
Priority:normal
Assigned:Crell
Status:closed (fixed)

Issue Summary

Although the profile module provides template files, it isn't split up into profile.admin.inc or profile.pages.inc. Is there any reason why it isn't?

Login or register to post comments

Comments

#1

Posted by Crell on November 13, 2007 at 12:58am
Assigned to:Anonymous» Crell
Status:active» needs review

Primarily because when going through the list of modules I somehow managed to flag it as having no page callbacks to factor out, which is of course flat wrong. Thanks for the catch. :-) Split patch attached. Cuts out just under half the module, too.

AttachmentSizeStatusTest resultOperations
profile.patch37.2 KBIgnored: Check issue status.NoneNone

#2

Posted by catch on November 13, 2007 at 12:18pm
Status:needs review» reviewed & tested by the community

OK I patched, enabled the module, made some fields, filled them in, visited both user profile and /profile page. All seems fine so RTBC.

#3

Posted by Dries on November 13, 2007 at 12:28pm
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks.

#4

Posted by Rob Loach on November 14, 2007 at 7:23am

Wow, that was fast.

#5

Posted by Anonymous on November 28, 2007 at 7:32am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.