Performance improvements for skinr_preprocess()

Reviewing D7 patch:
Have you run any performance tests to prove the efficacy of this patch?
Both skinr_get_skin_info() and theme_get_registry () are cached in their own functions. The only one that has no caching (which seems fairly minimal) is skinr_current_theme().

There is a whole article on this patch
http://2bits.com/cpu/solving-high-cpu-usage-and-reducing-page-generation...

I did the same tests as the article described in the drupal 7 version, and with or without the patch I get pretty much identical results.
Perhaps the problems are only there on the 6.x versions?

EDIT: Running tests on D6-2.x I'm not getting very different results either between the two versions.
EDIT 2: Now, granted, I'm working with a close to vanilla site with a few skins applied. Considering this is a small patch that might improve performance, but has no negatives to it, I'll add it (with some minor tweaks).

Attached is my updated patch. It's slightly cleaner and has inline comments.

And here's the D6-2.x patch.

And lastly, the 6.x-1.x patch.

All have been committed.

I've tested it, surprisingly it makes difference - 70 calls to skinr_preprocess, and difference about 90 to 130 ms on one of my Drupal 6 installations. Thanks for that patch

Adding link to article describing the issue.

+++ b/skinr.module
@@ -334,8 +340,8 @@ function skinr_preprocess(&$vars, $hook) {
+          if (!empty($data['info'][$current_theme]['skins'][$skin]['stylesheets'])) {
+            foreach ($data['info'][$current_theme]['skins'][$skin]['stylesheets'] as $media => $stylesheets) {

Oops, $current_theme is removed above (should be string literal 'current_theme'). (probably should have opened a new issue since this is already merged... apologies if that's the case)

See #2630622: Undefined variable: current_theme for followup problem.