Closed (fixed)
Project:
Superfish Dropdown Menu
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 Feb 2013 at 23:52 UTC
Updated:
18 Aug 2013 at 21:01 UTC
After I have updated the module to the latest dev version of Feb 8, 2013, my FlexSlider and Galleria on the same page were broken.
If I remove the Superfish menu, both of them were backed to normal.
In Firebug I caught the below error:
TypeError: list.sfsmallscreen is not a function
list.sfsmallscreen(options.plugins.smallscreen);
http://my-url/sites/all/modules/superfish/superfish.js -- Line 31To fix this, I have to delete the below few lines in the module's superfish.js:
if (options.plugins.smallscreen || false) {
list.sfsmallscreen(options.plugins.smallscreen);
}
I am not sure about the function of the above removed lines, so I am not sure what side effect that my action will bring.
Comments
Comment #1
aglobalwander_ commentedI have the same issue with a flex slider gallery. I haven't tried the suggestion above yet but am curious as to what the fix will be.
Comment #2
aglobalwander_ commentedI should have read the instructions more clearly. After updating the libraries superfish folder and clicking save configuration on the superfish config page everything works as expected. Thanks for a great module.
Comment #3
deanflory commentedYeah, it breaks all fieldset toggle-downs too. I'll try what #2 recommended and read the readme.
Comment #4
deanflory commentedI updated the superfish library.
https://github.com/mehrpadin/Superfish-for-Drupal/zipball/master
I edited and clicked "Save Configuration" on the Superfish Module admin page.
/admin/config/user-interface/superfish
I edited and clicked "Save block" on each Superfish menu block.
/admin/structure/block/manage/superfish/1/configure
/admin/structure/block/manage/superfish/2/configure
/admin/structure/block/manage/superfish/3/configure
/admin/structure/block/manage/superfish/4/configure
Flushed all caches.
The superfish update is still causing fieldset un-collapsing (toggle-downs) to not work properly, so there is definitely an error somewhere. At least after 3 days I've found the problem and can just back-track to the old module version. Moving on...
Reverting back to the previous version indeed allows the toggle-downs to again function properly.
Comment #5
retiredpro commentedi had the same error on drupal 6 when i updated to the latest dev version and library of superfish. it looks like the superfish drupal configuration page is missing a filepath for sfsmallscreen.js
so i added the following line to my superfish library paths and it fixed the issue for me.
sites/all/libraries/superfish/sfsmallscreen.js
Comment #6
dddave commentedHad the same problems but ultimately it was my fault for not uploading the right version of the library. Unless somebody can show that this breaks something on a correct install I set this to fixed.
Comment #7
deanflory commentedAdding the library path on the Superfish settings page fixed the issue:
sites/all/libraries/superfish/sfsmallscreen.js
Comment #8
metakel commentedYes, #7 fixes the problem.
However, it seems that the file downloaded from the link to the Superfish-for-Drupal on the project page does not contain the sfsmallscreen.js. We better go to the Github project page and download the zip file there directly.
Comment #9
deanflory commentedWhoa, good catch metakel.
grrr
Comment #10
dddave commentedRe #8,9: This is actually described on the modules page under "latest development version".
Comment #11
deanflory commentedYes that the link to sfsmallscreen.js is on the modules page, but the fact that that sfsmallscreen.js file itself isn't in the library that is to be downloaded isn't noted.
Comment #12
dddave commentedSee #1952644: File not found: sites/all/libraries/superfish/sfsmallscreen.js
Comment #13
mehrpadin commentedHey everybody,
Ok, I've edited it, should be more clear now, please take a look.
:)
Comment #14
sportel commentedI'm not sure what to put on the Superfish settings page. Do I add just the library path for Superfish (sites/all/libraries/superfish), or just the library path for the sfsmallscreen.js file (sites/all/libraries/superfish/sfsmallscreen.js), or the comlete paths to all the files in the library?
Thanks,
Mike.
Comment #15
deanflory commentedsportel, here's what I have for settings:
Path to Superfish library
sites/all/libraries/superfish/jquery.hoverIntent.minified.js
sites/all/libraries/superfish/jquery.bgiframe.min.js
sites/all/libraries/superfish/superfish.js
sites/all/libraries/superfish/supersubs.js
sites/all/libraries/superfish/supposition.js
sites/all/libraries/superfish/sftouchscreen.js
sites/all/libraries/superfish/sfsmallscreen.js
Comment #16
sportel commentedThanks, I installed and activated the superfish module before I copied the superfish library to it's folder. The module doesn't pick up the paths by itself. It works fine now.
Mike.
Comment #18
jackhutton commenteddunno if i can reopen this.. but, I'm having this issue with a flexslider sharing the landing page with superfish menus
The flexslider does not render when I enable the superfish menu as the main menu.
I've updated the libraries .. reviewed inclusion of the noted files and path configurations in #15 ..
I do see a single error using firebug on line 39 of supersubs.js
I see posts mentioning the z-index..
but not having success getting the superfish menu to render with the flexslider
any thoughts?
thank you