The bug is here:

$this->query = current(explode(" more:", $this->query)); //resume $this->query to its original value (no categories)

The links are built with +more: not with a space.

CommentFileSizeAuthor
#12 gss_type-filter-bugfix-1917020-2.patch769 bytesdhavyd
#1 type-filter-bugfix-1917020-1.patch794 bytesJohnny vd Laar

Comments

Johnny vd Laar’s picture

Johnny vd Laar commented
StatusFileSize
new type-filter-bugfix-1917020-1.patch794 bytes

And a patch.

Johnny vd Laar’s picture

Johnny vd Laar commented
Status: Active » Needs review
dhavyd’s picture

dhavyd commented

Thanks! I'll check the patch and apply it so the fix appears on the next release...

dhavyd’s picture

dhavyd commented

The patch is applied and the changes will appear on the next release... Thanks!

dhavyd’s picture

dhavyd commented
Status: Needs review » Reviewed & tested by the community
Johnny vd Laar’s picture

Johnny vd Laar commented

What is the difference between "+more" and " more" because the google cse demo page seems to use " more"?

And I am getting more results if I change the code to " more" (the same results as the google cse demo page gives.

Johnny vd Laar’s picture

Johnny vd Laar commented
Status: Reviewed & tested by the community » Needs review
dhavyd’s picture

dhavyd commented

I don't know what the difference is... Have you figured out what it is?

Johnny vd Laar’s picture

Johnny vd Laar commented

No I use " more" as it gives the same results as GCSE demo and my client uses that to verify if our code works ;-)

dhavyd’s picture

dhavyd commented

Ok, then I think I can remove the "+". Is it this row we are talking about?
$this->query = current(explode("+more:", $this->query)); //resume $this->query to its original value (no categories)
It was your patch above that added the sign... Should I remove it?

Johnny vd Laar’s picture

Johnny vd Laar commented

Yes I think you should.

dhavyd’s picture

dhavyd commented
StatusFileSize
new gss_type-filter-bugfix-1917020-2.patch769 bytes

Should it be like this?

Johnny vd Laar’s picture

Johnny vd Laar commented
Status: Needs review » Reviewed & tested by the community

Yeah I think so!

dhavyd’s picture

dhavyd commented
Status: Reviewed & tested by the community » Fixed

Done! This fix is coming up in the next release...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.