Preg match to find node id should have a + for node ids bigger then 9 [#1917118]

preg_match_all('/node\/(\d)/', $system_path, $matches, PREG_SET_ORDER);

should be:

preg_match_all('/node\/(\d+)/', $system_path, $matches, PREG_SET_ORDER);

Comment	File	Size	Author
#2	nodeids-pregmatch-1917118-2.patch	682 bytes	Johnny vd Laar
#1	nodeids-pregmatch-1917118-1.patch	611 bytes	Johnny vd Laar

Comments

Johnny vd Laar commented 14 February 2013 at 11:22

Status:

Active

» Needs review

Status	File	Size
new	nodeids-pregmatch-1917118-1.patch	611 bytes

And a patch.

Johnny vd Laar commented 14 February 2013 at 11:55

Status	File	Size
new	nodeids-pregmatch-1917118-2.patch	682 bytes

A slightly better version which uses preg_match instead of preg_match_all (we will only have one node id anyway).

dhavyd commented 18 February 2013 at 07:27

Thanks! I'll check the patch and apply it so the fix appears on the next release...

dhavyd commented 19 February 2013 at 20:02

Status:

Needs review

» Reviewed & tested by the community

The patch works fine and I've applied it. The changes will appear in the next release... Thanks!

dhavyd commented 2 March 2013 at 10:47

Status:

Reviewed & tested by the community

» Closed (fixed)