I've added some minor support for product tracking in this patch.

CommentFileSizeAuthor
#1 1917344-adform-product-tracking-1.patch4.35 KBkasperg
adform-product-tracking.patch3.71 KBElvar

Comments

kasperg’s picture

kasperg commented
StatusFileSize
new 1917344-adform-product-tracking-1.patch4.35 KB

The javascript breaks for clients with ad blockers enabled as the adf object is not available. I have added a bit of defensive coding and cleaned the module up as well.

xen’s picture

xen commented

I'm not sure about this. I feel it's to specific to warrant configuration in the module.

Will the configuration options really make it possible for someone to implement product tracking without writing any code? If not, I think it'll be better just to let an addon module add the JS for tracking products itself. I'd suggest a hook, but I can't even see the base for that, as there don't seem to be any interaction from the base tracking functions to the product tracking functions. At best, adform.module could add the JS and a helper JS function for tracking products for third party modules to call.