This module was inspired by a thread on the Drupal.org forums in 2008 about adding headers to sections of menu items within a menu. Menu Headers adds this functionality in a graceful, and lightweight configuration page attached to each menu's active links.

Use

  1. To use this module, go to Admin->Structure->Menus->[Menu Name]
  2. Click "Edit menu item headers" in the active links section at the top of the page.
  3. Open a menu link section, select a header size and type in a title
  4. Click Save

The header will appear directly above the menu link that you chose.

Drupal core

7.x

Sandbox Page

http://drupal.org/sandbox/zbabtkis/1917610

Contribute

Git command: 

git clone --recursive --branch 7.x-1.0 http://git.drupal.org/sandbox/zbabtkis/1917610.git menu_headers
cd menu_headers

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Also please fix your git branch as indicated on http://ventral.org/pareview/httpgitdrupalorgsandboxzbabtkis1917610git

npscode’s picture

npscode commented
Status: Needs review » Needs work

Hi zbabtkis,

Comments after quick manual review:

You should use version specific branch. See http://drupal.org/node/1015226.

Try to use standard way of drupal 7 for selecting data from tables. refer : api.drupal.org/api/drupal/includes!database!database.inc/function/db_select/7. db_query() (at line 147 menu_headers.module) will work but try to avoid this in drupal 7.

Run code review on the module and remove all coding style/formatting issue as per drupal standards.

Thanks.

aw030’s picture

aw030 commented

Automated review:
PAreview.sh on ventral.org: http://ventral.org/pareview/httpgitdrupalorgsandboxzbabtkis1917610git Found some problems
Coder module: "Coder found 1 projects, 3 files, 102 normal warnings,..." (all for incorrect coding conventions)

Manual review:

- Install a fresh drupal 7.19
- Move the module folder to sites/all/modules
- Install module
- Go to admin/structure/menu/manage/[menu-name]
- Tried main-menu, navigation and a custom created menu
- Clicked "Edit menu item headers" in links section
- Entered a text to "Menu Header" formular field and saved.
- No "headers" appearing anywhere on menu-items, where i can see these headers now?

Issues:
1. Headers not become visible (the custom headers are delivered to frontend in the cddata block, but it seems that the jQuery routine not works well).

Other:
You should move the project on git from head to branch following the right naming pattern.
In function menu_headers_set_titles() you could optimize the amount of triggered db calls using a batch-logic, but this is only a suggestion if handling a huge amount of menu-items

Status stays "needs work".

dDoak’s picture

dDoak commented

Hi,

A quick manual review :
- use spaces instead of tabs for your indentation
- in menu_headers_menu_local_tasks_alter put a break before default statement
- in menu_headers_menu, try to define your own permission, "administer nodes" is too general....

PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.