We wanted a way for people to go to a specific horizontal tab by using the format of http://drupal.org/blah#test. I created a patch that would allow people to add a custom id under the manage display tab for a specific content type. The id field is only available for each horizontal tab item. If the field is empty it uses the default naming that field_group already creates.

Please review and see if this is worth having in the module. I believe having a way to link to specific tab is useful and also having the freedom to name it the way we want.

Also this is my first patch. I apologize for my noobness and the errors I made. I will take any suggestions and improve in my process

CommentFileSizeAuthor
#3 field_group-remade_patch-1917674-3.patch3.79 KBmyoung
#2 working_version-1917674-2.patch0 bytesmyoung
#1 field_group-1917674-1-add_hash_tag_link_ability.patch3.17 KBmyoung

Comments

myoung’s picture

myoung commented
StatusFileSize
new field_group-1917674-1-add_hash_tag_link_ability.patch3.17 KB

DO NOT USE THIS PATCH

myoung’s picture

myoung commented
StatusFileSize
new working_version-1917674-2.patch0 bytes

DO NOT USE THIS ONE

myoung’s picture

myoung commented
StatusFileSize
new field_group-remade_patch-1917674-3.patch3.79 KB

USE THIS ONE

rakesh.nimje84@gmail.com’s picture

rakesh.nimje84@gmail.com commented

#3 Worked for me exact the way I needed.
Great work myoung

Ndesign’s picture

Ndesign commented

confirm as well for me...hope this becomes part of the core module soon. thank you so much for the help myyoung!

Bernsch’s picture

Bernsch commented
Status: Needs review » Reviewed & tested by the community
kingandy’s picture

kingandy
he/him
commented
Version: 7.x-1.1 » 7.x-1.x-dev
Status: Reviewed & tested by the community » Needs work

Patch appears to be built against 7.x-1.x-dev - but does behave as expected.

kingandy’s picture

kingandy
he/him
commented
Status: Needs work » Reviewed & tested by the community

(Whoops, was updating the status to "needs work" until I realised why the patch wasn't applying)

nils.destoop’s picture

nils.destoop commented
Status: Reviewed & tested by the community » Fixed

I changed the way of adding the ID input to the formatter settings, but this feature is now committed to dev. Thx :)

okeedoak’s picture

okeedoak commented

Can we get this for vertical tabs too?

MO-2’s picture

MO-2 commented

This is fantastic. Works great in latest release - 7.x-1.2.

Quick question on a use case (hopefully I'm missing something obvious):

Is there a way to link to the tab from within the page without reloading the page?

For example, I have a few tabs with IDs named (#)cool and (#)cooler. I would like to create links at the top of the page that jump to the bottom of the page and open the tab without reloading the page. Is this possible? How would you implement?

I tried adding this html at the top of the page:

<a href="#cooler">Go to Cooler </a>

Thanks and great work on this much needed feature!

MO-2’s picture

MO-2 commented
Category: feature » support
Status: Fixed » Active
mel-miller’s picture

mel-miller commented

Has anyone used this with 7.x-1.3 yet? Does it work?

mel-miller’s picture

mel-miller commented
Issue summary: View changes

Explaining my noobness

  • Commit a3b6dc2 on 7.x-1.x, 8.x-1.x authored by myoung, committed by zuuperman: 
    Issue #1917674 by myoung: Added Needed a way for horizontal tabs to be...
Collins405’s picture

Collins405 commented
Issue summary: View changes

Is this available for Vertical tabs as well?

  • zuuperman committed a3b6dc2 on 8.x-3.x authored by myoung 
    Issue #1917674 by myoung: Added Needed a way for horizontal tabs to be...
sime’s picture

sime
any/any
Location Melbourne
commented
Status: Active » Fixed

Commit happened. Marking fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.