The function db_placeholder() was removed from D7, yet an instance was found in code for Spaces

I found a little hitch in the Spaces code, where db_placeholder() was still being called in spaces_handler_filter_spaces_feature.inc. I've included a small patch for anyone interested in the fix. It's a quick one.

Proposed resolution

The patch below uses the correct syntax for calling the add_where function from the Views query plugin, which Spaces feeds the it's query to. It also removes the db_placeholder() call.

CommentFileSizeAuthor
spaces-removing-db_placeholder-func.patch1.39 KBraycascella

Comments

raycascella’s picture

raycascella
he/him
commented
Status: Patch (to be ported) » Active
raycascella’s picture

raycascella
he/him
commented
Status: Active » Needs review
drupalgideon’s picture

drupalgideon
Location London
commented

Minor comment but there should be a space before $types and before 'IN' in your patch as per https://drupal.org/coding-standards#functcall

$this->query->add_where($this->options['group'], "$table.type", $types, 'IN');
webflo’s picture

webflo commented
Status: Needs review » Fixed

Commit 7cd10c0 on 7.x-3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.