Issues using unsupported PayPal currencies

What happens is upon payment completion, you'll get an IPN from PayPal verifying the payment amount. When that comes in, Commerce will create a completed payment transaction in whatever amount was actually paid. If the customer tried to scam you, the order balance would continue to be positive. This is why we advise sites not to take any irreversible fulfillment action prior to receiving a paid in full notification - this is facilitated by the "When an order is first paid in full" event. There's also an order balance comparison condition for use at other times. There should be more discussion of this in the queue.

Additionally, at least in 2.x (and I believe even before in 1.x), our modules facilitate the conversion of payment amounts into whatever you select as the default currency in your WPS configuration. This means all you really need to do is keep your currency info array up to date with the proper conversion rate from Rand to Dollars, and it should automatically be converted upon redirect to PayPal and when calculating the order balance.

I did just realize we'll need to store the currency conversion rate to ensure we can calculate the order balance properly if the conversion rate has changed from one day to the next. Added that to the Commerce roadmap for now.

Finally, the reason 'terminal' is set to FALSE is because technically speaking PayPal WPS isn't supposed to be used by a merchant on behalf of a customer.

Hi

I have a store in Bolivia that sends payments to paypal. Like you said, we are handling the currency conversion (not with the multicurrency module but with two simple functions:

/**                                                                                  
 * Implements hook_commerce_currency_info_alter().                                   
 */                                                                                  
function web2print_cart_commerce_currency_info_alter(&$currencies, $langcode) {      
  $currencies['BOB']['symbol_placement'] = 'after';                                  
  $currencies['BOB']['code_placement'] = 'hidden';                                   
  $currencies['BOB']['conversion_callback'] = 'web2print_cart_currency_conversion';  
  $currencies['USD']['conversion_callback'] = 'web2print_cart_currency_conversion';  
}                                                                                    
                                                                                     
function web2print_cart_currency_conversion($amount, $currency_code, $target_currency_code) {
  // Skip - makes no sense to calculate here.                                        
  if ($currency_code == $target_currency_code) {                                     
    return $amount;
  } 
  
  watchdog('web2print', "Converting $amount $currency_code to $target_currency_code");      
  $USD_BOB = (float) variable_get('currency_usd_2_bob', 6.97);

  if ($currency_code == 'USD' && $target_currency_code == 'BOB') {                   
    return $amount * $USD_BOB;                                                       
  }
  else if ($currency_code == 'BOB' && $target_currency_code == 'USD') {              
    return $amount / $USD_BOB;                                                       
  }
}   

But the problem that I have is that the transaction is not triggering the "order is payed in full rule" because the function that calculates the balance of the order: [commerce_payment_order_balance](http://www.drupalcontrib.org/api/drupal/contributions!commerce!modules!p...) actually returns `FALSE` when you have amounts in more than one currency.

So, I have my prices in BOB. When going to paypal I see that the currency conversion is happening fine and I'm able to pay in USD in paypal. But when the IPN comes back I receive the payment in USD and no conversion is made back to BOB, they payment is stored in USD, so when the payment modules checks the balance to see if it needs to trigger the 'payed in full' rule it gets false instead of a balance of 0.

I found the issue, the module is using the function `commerce_currency_convert` when sending the request to paypal, but when receiving the response through the IPN it is not calling the conversion function.

Here is a patch to add that conversion.

I'm leaving this issue as closed and opened a new one here: https://www.drupal.org/node/2595243