Putting contrib modules into drupal/modules/ is not really cool. It violates a structure that makes upgrades and multi-site installations run a lot more smoothly, and using sites/all/ has been advised in the handbook and in sites/all/README.txt.

With that in mind, I suggest that INSTALL.txt be amended to direct the user to sites/all/modules/ instead of modules/.

CommentFileSizeAuthor
#3 audio_installtxt_directory-191812-3.patch1.93 KBcburschka
#1 audio_installtxt_directory-191812-1.patch1.91 KBcburschka

Comments

cburschka’s picture

cburschka
they
commented
Status: Active » Needs review
StatusFileSize
new audio_installtxt_directory-191812-1.patch1.91 KB

Patch applies to DRUPAL-5 branch.

drewish’s picture

drewish commented
Status: Needs review » Needs work

your right, that's left over from the 4.7 days. the changes look good to me other than the directory tree isn't indented consistently. if you'll fix that and re-roll i'll get this committed right off.

cburschka’s picture

cburschka
they
commented
Status: Needs work » Needs review
StatusFileSize
new audio_installtxt_directory-191812-3.patch1.93 KB

I hate vim's auto-indentation.

Well, I've used a text replacement to remove tabs, and then carefully re-indented the lines with spaces; this new patch should be fine.

drewish’s picture

drewish commented
Status: Needs review » Fixed

thanks, it looks great. i've committed it to DRUPAL-5 and HEAD.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.