To reproduce:

have more than 1 extra pane, go to list of extra panes - the operations links for the very top pane will be in order but the next one will have operations links for the one above first and then for itself, the 3rd one - for the top 2 and so on.

CommentFileSizeAuthor
#6 commerce_extra_pane-fixed-duplicated-operations-link-1918748-06.patch1.14 KBjohnle

Comments

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Active » Fixed

Thanks for the catch, fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

niki v’s picture

niki v commented
Version: 7.x-1.x-dev » 7.x-1.1
Status: Closed (fixed) » Active

This bug appears to be back in 7.x1.1

I'm experiencing this exactly as described above

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Active » Closed (fixed)

Please try the -dev version.

niki v’s picture

niki v commented

Thanks. I tried but I get a fatal error if I try to uninstall 7.x-1.1 The site was already live when I noticed this.

Fatal error: Call to undefined function commerce_extra_panes_get_panes() in /home/MYUSERNAME/public_html/sites/all/modules/commerce_extra_panes/modules/commerce_extra_panes_termsofservice/commerce_extra_panes_termsofservice.install on line 13

Should I just delete the module on the server and then try and install the -dev version or is it better to just wait for the new release? There are other ways to edit these nodes

johnle’s picture

johnle commented
Issue summary: View changes
StatusFileSize
new commerce_extra_pane-fixed-duplicated-operations-link-1918748-06.patch1.14 KB

I saw this issue being fixed but no patch to review. I've got the commit and converted into a patch from https://git.drupalcode.org/project/commerce_extra_panes/commit/bd2cfb054....

Some extra notes, I don't think we need the operations array at the very top of the theme_commerce_extra_panes_settings_list function, only in the foreach where the operation links are reset.