Posted by Berdir on February 16, 2013 at 4:24pm
11 followers
| Project: | Drupal core |
| Version: | 8.x-dev |
| Component: | language system |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | API clean-up, D8MI, language-content |
Issue Summary
The translatable tag was an attempt to make certain things that weren't translatable translatable by providing a schema and query flag/tag that would all contrib to alter things queries and e.g. join a table that contains the translation.
I think I've written the only implementation of that tag and while it kinda works, it is too limited to actually work. There is no way to control when the original should be displayed and when it should be translated into which language.
I think the two main approaches for translating things are now content/entity translation and config translation.
Comments
#1
While a number of table columns still have the tag (I assume partially due to copy paste of definitions and forgetting to remove them), it looks like the only remaining cases where it is added to a query are node types and taxonomy terms.
Note 1: It is save to remove this flag from update functions as it never actually *did* something, it is just meta information for anyone who is parsing schema information, just like serialized.
Note 2: Those taxonomy term autocomplete queries should probably use the term storage controller to load the terms otherwise we won't be able to make them translatable properly.
#2
This looks good to me and I fully agree that the two main approaches for translating things are now content/entity translation and config translation. In note 2 are you referring to the two occurrences in
TermStorageControllerandtaxonomy.pages.inc?#3
Hm, I think I forgot the save a few files, the patch looks too small.
#4
This is more like it.
@plach: The one in taxonomy.pages.inc and (views...)/ajax.inc. Also, taxonomy_get_tree() is messy as well, but it at least optionally allows to load entities. We need lazy loading entites to clean that up. But neither are blocking this.
#5
#6
Looks good, thanks. I agree we don't need update functions for this: nothing in core ever used this stuff, maybe a small change notice.
#7
change notice written.
#8
Asking for a re-test.
#9
#4: translatable-removed-1919022-4.patch queued for re-testing.
#10
The last submitted patch, translatable-removed-1919022-4.patch, failed testing.
#11
I also support this change. (Got here via noticing the pre-written change notice :)
#12
Re-roll after custom_block went in.
#13
Didn't want to set it to RTBC.
#14
Looks good to me :)
#15
Less code, less confusion. Hooray!
Committed and pushed to 8.x. Thanks!
Looks like the change notice was already taken care of, so marking to fixed.
#16
Automatically closed -- issue fixed for 2 weeks with no activity.