Download & Extend
Issues

Create configuration schemas for field module

Posted by vijaycs85 on February 16, 2013 at 9:13pm
Project:Drupal core
Version:8.x-dev
Component:field system
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:Configuration schema, Configuration system, D8MI, language-config

Issue Summary

This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.

Proposed solution

Create a configuration schema for field module.

Schema in place

Schema not yet in place
field.settings.yml

Login or register to post comments

Comments

#1

Posted by vijaycs85 on February 16, 2013 at 10:01pm
Status:active» needs review

Adding schema file...

AttachmentSizeStatusTest resultOperations
1919164-field-schema.patch362 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 50,634 pass(es).View details

#2

Posted by Vikas Negi on February 22, 2013 at 10:27am

Re-rolling with code style fixes (http://drupal.org/node/1905070#codestyle)

AttachmentSizeStatusTest resultOperations
1919164-field-schema-2.patch787 bytesIdleFAILED: [[SimpleTest]]: [MySQL] 52,220 pass(es), 5 fail(s), and 0 exception(s).View details

#3

Posted by System Message on February 22, 2013 at 11:35am
Status:needs review» needs work

The last submitted patch, 1919164-field-schema-2.patch, failed testing.

#4

Posted by vijaycs85 on February 22, 2013 at 12:11pm

+++ b/core/modules/field/config/schema/field.schema.ymlundefined
+++ b/core/modules/field/config/schema/field.schema.ymlundefined
@@ -0,0 +1,9 @@

@@ -0,0 +1,9 @@
+# Schema for configuration files of field module.

missing 'the' as per code style :(

+++ b/core/modules/menu/config/menu.settings.ymlundefined
@@ -1,3 +1,3 @@
-main_links: main
+smain_links: main
secondary_links: account
override_parent_selector: '0'

typo/mistake?

#5

Posted by Vikas Negi on February 22, 2013 at 12:41pm
Status:needs work» needs review

Fixed changes as per the above comments.

AttachmentSizeStatusTest resultOperations
1919164-field-schema-5.patch452 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 52,208 pass(es).View details
1919164-diff-2-5.txt1.09 KBIgnored: Check issue status.NoneNone

#6

Posted by sandipmkhairnar on March 4, 2013 at 1:17pm

Correct the label for purge batch site and update the patchschema form

AttachmentSizeStatusTest resultOperations
1919164-field-schema-6.patch480 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 52,198 pass(es).View details
field-schema-form.png16.7 KBIgnored: Check issue status.NoneNone

#7

Posted by vijaycs85 on March 4, 2013 at 1:22pm

+++ b/core/modules/field/config/schema/field.schema.ymlundefined
+++ b/core/modules/field/config/schema/field.schema.ymlundefined
@@ -0,0 +1,9 @@
+# Schema for configuration files of the Field module

One minor issue - Comment missing a full stop(".") at the end.

#8

Posted by System Message on March 4, 2013 at 2:12pm
Status:needs review» needs work

The last submitted patch, 1919164-field-schema-6.patch, failed testing.

#9

Posted by vijaycs85 on March 4, 2013 at 2:26pm
Status:needs work» needs review

#6: 1919164-field-schema-6.patch queued for re-testing.

#10

Posted by sandipmkhairnar on March 5, 2013 at 10:05am

Thanks @vijaycs85. Update patch as per the comment

AttachmentSizeStatusTest resultOperations
1919164-field-schema-10.patch481 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 52,210 pass(es).View details

#11

Posted by sidharthap on March 16, 2013 at 6:32am

I tested the patch #10, It works. Attach the screen shot. Thank you @sandipmkhairnar.

image

AttachmentSizeStatusTest resultOperations
1919164-11.jpg27.26 KBIgnored: Check issue status.NoneNone

#12

Posted by vijaycs85 on March 16, 2013 at 6:45am
Status:needs review» reviewed & tested by the community

Thanks @sidharthap and @sandipmkhairnar. Looks good to go to me too.

#13

Posted by webchick on March 17, 2013 at 4:36pm
Status:reviewed & tested by the community» fixed

Committed to 8.x, thanks! I'll push once testbot has caught up a bit.

#14

Posted by System Message on March 31, 2013 at 4:40pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.